Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/system/lib/Drupal/system/Tests/Common/JavaScriptTest.php

Line 482: Unused local variable $result

CommentFileSizeAuthor
#4 drupal-core-remove-unuses-local-variable-2080321-4.patch1.05 KBsandergo90
#2 drupal8.system-module.2080321-2.patch1018 bytesG2

Comments

G2’s picture

G2 commented
Assigned: Unassigned » G2
G2’s picture

G2 commented
Status: Active » Needs review
StatusFileSize
new drupal8.system-module.2080321-2.patch1018 bytes

Removed the variable assignment from line 482.

Status: Needs review » Needs work

The last submitted patch, drupal8.system-module.2080321-2.patch, failed testing.

sandergo90’s picture

sandergo90 commented
Assigned: G2 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unuses-local-variable-2080321-4.patch1.05 KB

The patch was not ok. It removed the line of drupal_add_library completely and tests were failing then. I've attached a patch where $result will be removed but drupal_add_library will be kept.

parthipanramesh’s picture

parthipanramesh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.