Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variables

File /core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorLanguageTest.php

Line 68: Unused local variable $plugin_id
Line 81: Unused local variable $plugin_id
Line 89: Unused local variable $plugin_id
Line 111: Unused local variable $plugin_id
Line 116: Unused local variable $plugin_id

Files: 
CommentFileSizeAuthor
#8 drupal-core-remove-unused-variable-2080113-8.patch2.64 KBdeneo
PASSED: [[SimpleTest]]: [MySQL] 59,185 pass(es). View
#6 2080113-remove-unused-variable-5.patch2.66 KBdeneo
FAILED: [[SimpleTest]]: [MySQL] 59,142 pass(es), 1 fail(s), and 0 exception(s). View
#4 2080113-remove-unused-local-4.patch2.62 KBrhm5000
PASSED: [[SimpleTest]]: [MySQL] 59,323 pass(es). View

Comments

chertzog’s picture

Status: Active » Closed (duplicate)
angel.h’s picture

Status: Closed (duplicate) » Needs work
angel.h’s picture

Status: Needs work » Active

This issue shouldn't have been closed - see https://drupal.org/node/2080311#comment-7909573.

rhm5000’s picture

Status: Active » Needs review
FileSize
2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 59,323 pass(es). View
parthipanramesh’s picture

Issue summary: View changes
Status: Needs review » Needs work

sorry, but I can't apply this patch..

deneo’s picture

Status: Needs work » Needs review
FileSize
2.66 KB
FAILED: [[SimpleTest]]: [MySQL] 59,142 pass(es), 1 fail(s), and 0 exception(s). View

patch

Status: Needs review » Needs work

The last submitted patch, 6: 2080113-remove-unused-variable-5.patch, failed testing.

deneo’s picture

Status: Needs work » Needs review
FileSize
2.64 KB
PASSED: [[SimpleTest]]: [MySQL] 59,185 pass(es). View
areke’s picture

Status: Needs review » Reviewed & tested by the community

The patch applies cleanly and takes care of the issue. Thank you!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.