Remove Unused local variable $correct_colors from /core/modules/system/lib/Drupal/system/Tests/Image/ToolkitGdTest.php [#2080103]

Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/system/lib/Drupal/system/Tests/Image/ToolkitGdTest.php

Line 250: Unused local variable $correct_colors

Comment	File	Size	Author
#1	2080103-remove-unused-variables-1.patch	738 bytes	rhm5000
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rhm5000 CreditAttribution: rhm5000 commented 13 September 2013 at 08:44

Status:

Active

» Needs review

File	Size
2080103-remove-unused-variables-1.patch	738 bytes

Comment #2

longwave

he/him

English

CreditAttribution: longwave commented 13 September 2013 at 10:47

Status:

Needs review

» Reviewed & tested by the community

Comment #3

catch

he/him

English

CreditAttribution: catch commented 25 September 2013 at 07:22

Hmm this actually looks like missing test coverage that was intended but never implemented. Since it's not there let's remove the variable, but please open an issue to add the coverage back and link from here?

Comment #4

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 2 October 2013 at 14:00

Status:

Reviewed & tested by the community

» Fixed

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables

It does the correct color test later in the same test...

            $color = $this->getPixelColor($image, $x, $y);
            $correct_colors = $this->colorsAreEqual($color, $corner);
            $this->assertTrue($correct_colors, format_string('Image %file object after %action action has the correct color placement at corner %corner.', array('%file' => $file, '%action' => $op, '%corner' => $key)));