Webform 4 has abandoned this variable in favor of one variable per node type. Patch to follow replaces references to the variable with calls to the new function "webform_node_types()" - but only if it exists, so backwards compatibility with webform 3.0 is preserved.

CommentFileSizeAuthor
#4 2079807-webform_entity-node-types-2.patch5.27 KBJon Pugh
#1 2079807-webform_entity-node-types.patch5.17 KBwodenx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wodenx’s picture

wodenx CreditAttribution: wodenx commented
FileSize
2079807-webform_entity-node-types.patch5.17 KB
wodenx’s picture

wodenx CreditAttribution: wodenx commented
Status: Active » Needs review
wodenx’s picture

wodenx CreditAttribution: wodenx commented

Actually - this change to webform is very recent -- https://drupal.org/node/2062235
But we should still support it.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh commented
Priority: Normal » Major
Issue summary: View changes
FileSize
2079807-webform_entity-node-types-2.patch5.27 KB

Rolled a new patch with a code comment on the new function.

Bumping to Major since it breaks compatibility with the latest version of webform.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Status: Needs review » Reviewed & tested by the community

This does what it says on the box and is certainly needed for webform 4.x compatibility.

robertwb’s picture

robertwb CreditAttribution: robertwb commented

Confirmed - this patch restores compatibility with latest Webform. It would be great to have this committed because it also breaks the patch: https://www.drupal.org/node/2209947

  • Jon Pugh authored 5af46aa on 7.x-1.x 
    Issue #2079807 by wodenx, Jon Pugh: Preserve compatibility with Webform...
AaronBauman’s picture

AaronBauman
he/him
CreditAttribution: AaronBauman commented
Status: Reviewed & tested by the community » Fixed

Committed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.