Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pomliane’s picture

Assigned: sbrissy-elypsia.fr » Unassigned
Status: Active » Needs review
Würden’s picture

That's not a patch, it's a diff... Please provide a valid patch.

dieuwe’s picture

Title: Modules doesn't work and no open's stat » Modules doesn't work and no open stats
Priority: Normal » Critical
Issue summary: View changes
Status: Needs review » Needs work
dieuwe’s picture

This is the best I could glean from the diff given by @sbrissy-elypsia.fr

It doesn't seem to "fix" anything for me though.

Würden’s picture

Thanks dieuwe. I haven't tested the patch in my installation but I sorted it out using the diff originally and it actually fixed it for me. The tab for statistics were just empty and now it's working for clicks. Open rate is still not working on my end unfortunately, using the latest version of simplenews.
It seems that the 1x1px image that is supposed to be inserted in every mail to record the open rate is not inserted. I haven't had the time to come up with a fix yet.

keyral’s picture

Hello,

your patch fix the problem well, but generates error and incapicité use in translation module.

No solution to the problem set.

linguisticstudio’s picture

Assigned: Unassigned » linguisticstudio
Status: Needs work » Patch (to be ported)
FileSize
36.81 KB
dieuwe’s picture

Can you give a little description of what you're trying to do with that patch? I'll have a proper look on Friday and try to get a fix for this committed.

dieuwe’s picture

Title: Modules doesn't work and no open stats » Statistics tab does not display any results
Assigned: linguisticstudio » Unassigned
Issue summary: View changes
Status: Patch (to be ported) » Needs review

  • Commit 415b96d on 7.x-1.x by dieuwe:
    Addressed some of the problems raised in issue #2079301, email links and...
dieuwe’s picture

Status: Needs review » Closed (fixed)

I believe that I have addressed most of the issues raised here, please update to the latest dev version (should be up-to-date within 12 hours of this post).

It was noted the the open rate is not displayed, this is because that feature had not been implemented yet. I have opened a new issue for that: #2285547: Implement open rate in the statistics view.

@studiocommerce Your patch would not apply, see here for creating Drupal patches. Your default_view supplied was also not in English, but I have copied you changes to hook_views_data() which I will attribute to you when I commit those.

I will now close this issue, please open a new issue for related bugs, or reopen this issue if you still do not get proper links and click statistics when sending newsletters on the latest dev.