Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, i have some "Views Displays" with custom fields blocks but these blocks desappear after update to 7.x-2.5, it works with previous version but not with the last, is there any new feature to activate in this new version to show these blocks inside blocks?
by the time I return to 7.x-2.4
thanks
Comment | File | Size | Author |
---|---|---|---|
#22 | 2077943-22.patch | 5.01 KB | swentel |
#16 | 2077943-16.patch | 4.92 KB | swentel |
#7 | 2077943-7.patch | 2.8 KB | swentel |
#2 | example2.gif | 10.47 KB | Acertijo |
displaysuite.jpg | 35.33 KB | Acertijo |
Comments
Comment #1
swentel CreditAttribution: swentel commentedHmm, interesting. What kind of block should be rendered there ? Is it a view block, a contrib block, or just a custom block that you defined ?
Comment #2
Acertijo CreditAttribution: Acertijo commentedhi swentel, its a block that i defined with normal Text links, but now after your reply i have tried with view block and some others but i get the same blank space, i think its a bug because in 7.x-2.4 they show with the same configuration
Comment #3
swentel CreditAttribution: swentel commentedHmm, so, it 's a block you defined in code ? Could you share that code here if possible ?
I've been trying to reproduce, but I can't seem to find anything for now.
Moving to bug report, as my changes have clearly changed something somewhere, although I don't know what yet. Digging further myself too.
Comment #4
jstollerBumping the issue priority to major, since it's killing a significant feature.
I first noticed that all of my blocks provided by the Blockify module (and turned into DS block fields) were no longer displaying. This includes the Tabs and Messages blocks. The "Workbench information" block, provided by the Workbench module, was also gone. Upon further exploration, the default Drupal blocks don't seem to be displaying either. I couldn't get the basic "Powered by Drupal" block to display in a block field.
If I set my field to display a label on the Manage fields tab of my content type, then it does output a label, but there isn't any field content. If I set the Block field itself to "Show block title + content" then it outputs an empty h2.
Interestingly, blocks provided from the Bean module do display correctly.
Reverting to ds-7.x-2.4 restores block visibility.
Comment #5
swentel CreditAttribution: swentel commentedMarked #2079067: block fields with language restrict are not showing correctly as duplicate - I just might revert the changes I did.
Comment #6
swentel CreditAttribution: swentel commentedWell, core blocks should really work. I did have to visit admin/structure/blocks though to make sure everything is rehashed. But I'm digging further, because I don't get why everything is doing weird.
Comment #7
swentel CreditAttribution: swentel commentedBeen digging around a bit, got problems as well at some stages. It would be awesome if you guys could test following patch.
Comment #8
PolI'm also having the same problem, I had to go back to 2.4 because I'm not having the time to test the patch. Sorry.
Comment #9
funature CreditAttribution: funature commentedi tested the patch, it was still not working. dblog shows
Notice: Undefined index: content in ds_render_block_field() (line 945 of /sites/all/modules/ds/ds.module).
Comment #10
jstollerI downloaded the latest dev and applied the patch from #7. It is definitely an improvement. My Blockify module blocks are displaying again (Tabs and Messages). I was also able to get the "Powered by Drupal" block to work in a block field.
The Workbench information block content still isn't showing, but it turns out that it doesn't work under ds-7.x-2.4 either, so that block may have a deeper issue.
The log reports the following errors:
Comment #11
jstollerWell, I think I figured out why the Workbench information block doesn't display, but I'm not sure there's anything you can do about it in DS.
The block is meant to display some messages related to the moderation state of the node. The function that creates those messages, workbench_moderation_messages(), is triggered on hook_node_view(). Now, I'm stepping way out of my comfort zone here, but I think DS is assembling its fields on hook_field_attach_view_alter(), which I'm guessing is executed before hook_node_view(). So workbench_block_view() is returning an empty array, which is confusing ds_render_block_field().
Unless you have any brilliant ideas, I assume there's nothing DS can do to display blocks that aren't ready when it renders its fields. Though DS should be prepared for hook_block_view() to return nothing in some cases and prevent the field from being added when that happens. And perhaps this could be documented somewhere? I'll post an issue in the Workbench Moderation queue to see if anything can be done on that side.
Comment #12
jstollerThe Workbench moderation issue is posted at #2079765: Workbench information block doesn't work with Display Suite custom view mode.
Other than that, this patch appears to fix my problems.
Comment #13
arx-e CreditAttribution: arx-e commentedWell, I had lost a custom pager block but it is happily back after applying the patch at #7 over 7.x-2.5+2-dev.
Comment #14
palamida CreditAttribution: palamida commentedI have the same problem with the Block field
- used to show the AddToAny module block -> AddToAny button block
- now DS is displaying the block title but no block content
regards
marko
Comment #15
voodoodan245730 CreditAttribution: voodoodan245730 commentedThis is happening to me as well. I had pre-defined view blocks with languages, I also had normal Drupal created blocks with the text fields. The views blocks were not considering Drupal's language module and displayed in double.
Now I still cant render the normal drupal generated blocks that contain simple text. The containing DIVS are generated, but not the content. Very strange
Comment #16
swentel CreditAttribution: swentel commentedHere's a patch that reverts the changes I've done, this equals the code as in 2.4 (with a tiny change/fix for translation).
I'll probably commit this during the weekend and do a hot-fix release as there were 2 other annoying bugs that came out of this release.
Comment #17
voodoodan245730 CreditAttribution: voodoodan245730 commentedThanks a lot Swentel!
I confirm the patch fixed the issue
Comment #18
voodoodan245730 CreditAttribution: voodoodan245730 commentedAlso, will you be updating the issue in the admin panel? After update, we cant drag and drop anymore, and the custom field windows wont open! Im using Jquery Update v1.7
Comment #19
cmseasy CreditAttribution: cmseasy commentedConfirm that the patch worked.
Had some missing blocks after updating to 2.5
Comment #20
swentel CreditAttribution: swentel commented@voodoodan245730 yes, that patch is already committed in the 7.x-2.x branch.
Comment #21
cmseasy CreditAttribution: cmseasy commentedBut I am still missing the drag en drop weight function: I rolled back to 2.4
Comment #22
swentel CreditAttribution: swentel commentedCommitted attached patch and pushed. New release fixing 3 annoying bugs : https://drupal.org/node/2081631
Comment #23
cmseasy CreditAttribution: cmseasy commented@swentel: thank you.
I updated to 7.x-2.6: I did not have issues.
Comment #24
arx-e CreditAttribution: arx-e commentedUpdated to 7.x-2.6 me too and I do not have issues.
Comment #25
Acertijo CreditAttribution: Acertijo commentedUpdated to 7.x-2.6, Perfect thanks
Comment #26
yeaha CreditAttribution: yeaha commentedhad same errors with 7.x-2.5, problem solved with 7.x-2.6, thank you