In the selectboxes on admin/settings/admin and admin/settings/performance, the brackets around the default value are missing. Enclosed little patch fixes that. No string changes involved.

CommentFileSizeAuthor
missing_brackets.patch1000 bytespancho

Comments

robertgarrigos’s picture

robertgarrigos commented
Status: Needs review » Reviewed & tested by the community

mmm I don't know why you say that the brackets are missing. Have they ever been there? In any case, I like to see default values more distinguished. This patch for me is ok.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

Where do these brackets come from? Some default options use dashes, like "-Please select-". I'd suggest doing a rundown of what markers are used for default options, and only then move into whatever direction.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Fixed » Reviewed & tested by the community

Nope, they've never been there. But given that default values, especially "none" are wrapped in brackets throughout core, one can assume that this is a standard. Especially if the standard makes a lot of sense.

edit: crossed post #3 (I answered to robertgarrigos). But now it's fixed anyway, and that is good. :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Fixed

Hm, indeed none is wrapped in brackets and we can apply the same logic to system default as well. Committed.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Reviewed & tested by the community » Fixed

Actually, I'd prefer to use ‹ (&lsaquo;) and › (&lsaquo;), as they look more elegant (Compare ‹none› to <none>).
But this is something we would have to change consistantly througout core, and I'd suggest to talk about that in the general context of D7 design improvements.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.