Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #1
Problem/Motivation
OverlayController has fallen behind a bit on latest standards:
- We can inject the token generator
- We can extend ControllerBase to use $this->t() and $this->currentUser()
- Also, #1978932: Convert overlay_ajax_render_region() to a Controller introduced some minor code-style problems
Proposed resolution
Fix the problems.
Related Issues
#1978932: Convert overlay_ajax_render_region() to a Controller
#1798296: Integrate CSRF link token directly into routing system
#1798296: Integrate CSRF link token directly into routing system
#2049159: Create a ControllerBase class to stop the boilerplate code madness
#2062151: Create a current user service to ensure that current account is always available
Comment | File | Size | Author |
---|---|---|---|
#1 | 2074125-1-OverlayController.patch | 3.56 KB | tstoeckler |
Comments
Comment #1
tstoecklerWhile I was at it I noticed a few other things that we can improve in OverlayController. Will update the issue summary.
Comment #1.0
tstoecklerUpdated issue summary for patch in #1
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedComment #2.0
ParisLiakos CreditAttribution: ParisLiakos commentedAdded #1798296: Integrate CSRF link token directly into routing system to list of related issues
Comment #3
nod_Overlay is dead to D8 #2088121: Remove Overlay.