Updated: Comment #1

Problem/Motivation

OverlayController has fallen behind a bit on latest standards:

  1. We can inject the token generator
  2. We can extend ControllerBase to use $this->t() and $this->currentUser()
  3. Also, #1978932: Convert overlay_ajax_render_region() to a Controller introduced some minor code-style problems

Proposed resolution

Fix the problems.

#1978932: Convert overlay_ajax_render_region() to a Controller
#1798296: Integrate CSRF link token directly into routing system
#1798296: Integrate CSRF link token directly into routing system
#2049159: Create a ControllerBase class to stop the boilerplate code madness
#2062151: Create a current user service to ensure that current account is always available

CommentFileSizeAuthor
#1 2074125-1-OverlayController.patch3.56 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

Title: Code-style follow-ups for "Convert overlay_ajax_render_region() to a Controller" » Improve OverlayController
Status: Active » Needs review
FileSize
3.56 KB

While I was at it I noticed a few other things that we can improve in OverlayController. Will update the issue summary.

tstoeckler’s picture

Issue summary: View changes

Updated issue summary for patch in #1

ParisLiakos’s picture

Component: base system » overlay.module
ParisLiakos’s picture

nod_’s picture

Issue summary: View changes
Status: Needs review » Closed (won't fix)

Overlay is dead to D8 #2088121: Remove Overlay.