Upgrade to Drupal 8 [#2073503]

Comment	File	Size	Author
#3	node_edit_protection-drupal_8-2073503-3.patch	19.38 KB	floretan
#1	node_edit_protection-drupal_8-2073503-1.patch	19.38 KB	shkiper
	8.diff	3.92 KB	thehong

Comment #1

shkiper CreditAttribution: shkiper as a volunteer commented 15 June 2016 at 05:38

Issue summary:

File	Size
node_edit_protection-drupal_8-2073503-1.patch	19.38 KB

I've made a Drupal 8 version of this module. Could someone please review my patch?

Log in or register to post comments

Comment #2

fornigam CreditAttribution: fornigam as a volunteer and at Cybage Software Pvt Ltd. commented 15 June 2016 at 05:51

Hi Shkiper,

Could you please provide sandbox or other link for download 'Node Edit Protection' in Drupal 8 ?

Log in or register to post comments

Comment #3

floretan CreditAttribution: floretan at Wunder commented 18 July 2016 at 09:49

Version:	7.x-1.0	» 7.x-1.x-dev
Status:	Needs review	» Reviewed & tested by the community

File	Size
node_edit_protection-drupal_8-2073503-3.patch	19.38 KB

2 files were hidden/shown/deleted

File	Size
8.diff	3.92 KB
node_edit_protection-drupal_8-2073503-1.patch	19.38 KB

The patch from @shkiper in comment #1 works (tested with simple text fields and with CKeditor). I also had a look at the code, everything looks good to me.

There was a warning about trailing whitespace when applying the patch, here's a functionally identical patch with the line endings fixed so that no warnings are thrown.

Log in or register to post comments

Comment #4

21 July 2016 at 13:57

czigor committed 902339c on 8.x-1.x authored by shkiper

Issue #2073503 by thehong, shkiper, floretan: Upgrade to Drupal 8

Log in or register to post comments

Comment #5

czigor CreditAttribution: czigor at Liip for FREITAG lab. AG commented 21 July 2016 at 14:05

Status:

Reviewed & tested by the community

» Fixed

Thanks for all the work on this! I have created a 8.x-1.x branch and a 8.x-1.x-dev release. Hopefully it will appear on the module page in the next 12 hours.