Part of #2046881: [meta] Avoid "early rendered" strings where beneficial to do so, build structured data to pass to drupal_render() once instead.

CommentFileSizeAuthor
#3 2072639-3.patch3.78 KBthedavidmeister
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented

postponed on #2072647: #theme 'maintenance_page' should support render arrays in #content

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Active » Postponed
thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
FileSize
2072639-3.patch3.78 KB

patch includes what's at #2072647: #theme 'maintenance_page' should support render arrays in #content.

As a bonus, we get the Drupal styles for the submit button.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Issue summary: View changes
Status: Postponed » Needs work

No longer postponed.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Status: Needs work » Closed (cannot reproduce)

Fixed already
\Drupal\system\Controller\DbUpdateController::info()

    $info[] = $this->t('Install your new files in the appropriate location, as described in the handbook.');
    $build['info'] = array(
      '#theme' => 'item_list',
      '#list_type' => 'ol',
      '#items' => $info,
    );
    $build['info_footer'] = array(
      '#markup' => '<p>' . $this->t('When you have performed the steps above, you may proceed.') . '</p>',
    );

    $url = new Url('system.db_update', array('op' => 'selection'));
    $build['link'] = array(
      '#type' => 'link',
      '#title' => $this->t('Continue'),
      '#attributes' => array('class' => array('button', 'button--primary')),
      '#url' => $url,
    );
    return $build;