hi,

for the fluxkraft distro, we are using composer & composer manager to include external php libraries.

i just wanted to ask if you are planning to support composer for adding further dependencies besides what gets listed in .make files.

here are some reference links:
https://drupal.org/project/fluxkraft_distro
https://drupal.org/project/composer_manager
http://drupalcode.org/project/fluxkraft_distro.git/blob/refs/heads/7.x-1...

greetings,
dasjo

CommentFileSizeAuthor
#11 composer_support-2069833-11.patch1.32 KByanniboi

Comments

patrickd’s picture

patrickd commented

While it's currently technically not possible it is definitely planned for the coming rewrite/relaunch of simplytest.me

Until then you can try to include a simplytest.make which first includes the build-*.make and then manually downloads the composer dependencies..

Sorry :/

patrickd’s picture

patrickd commented
Priority: Normal » Critical
Issue summary: View changes

Due to (https://groups.drupal.org/node/508662) removal of dependencies from GIT, adding composer support is now a critical problem for testing patches of Drupal Core on simplytest.me.

I'll need to find some way to do it..

xjm’s picture

xjm
she/her
Primary language English
commented

The issue was rolled back but recommitted now that github lifted the rate limits: https://groups.drupal.org/node/509719

So attempting the 8.1.x or 8.2.x branches on simplytest.me now fails.

nevergone’s picture

nevergone
Primary language Hungarian
commented

Drupal 8.1.0-beta2 is not working. Please enable composer support. Thanks!

patrickd’s picture

patrickd commented

Sorry that this took so long!

composer install is now executed for projects that have a composer.json

Drupal core 8.1.x seems to work fine with the changes.

But I'm afraid this will not work properly with distributions and sub-dependencies yet.

patrickd’s picture

patrickd commented

I'll need to see how I can use Composer manager on simplytest.me to get around these issues

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

patrickd - I’m at DevDaysMilan and looking do do exactly this with a distribution (and needing dependencies for address) so very happy to test anything you might have so far...

tamasd’s picture

tamasd commented

What is the status of the composer manager support? I would like to use a D7 module that has a composer dependency.

patrickd’s picture

patrickd commented

still not fully supported but composer install should be executed for your module. you could create a separate branch for your project and try it out from simplytest.me, please let me know how it goes.

sorry this is taking so long

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

Hey there, thanks for your work on this. I'm getting an error when trying to setup with fitbit module. The message isn't very helpful, just "An error occurred while installing the environment.". The module includes a composer.json file, so I suspected that was the problem, hence the post here. I tried address module though and that worked out fine. Not sure what's wrong.

yanniboi’s picture

yanniboi commented
Status: Active » Needs review
StatusFileSize
new composer_support-2069833-11.patch1.32 KB

Ok, so composer_manager is now "deprecated and no longer needed" according to the project page.

I spoke with @bojanz, and the ideal approach would be for simplytest.me to build drupal projects entirely using composer:

simplytest.me becomes just a UI for assembling a composer.json
you add the modules there, then shell out to run composer install
and you're done
no logic left
plus, you get to rely on the Composer cache that way

While this is a nice idea to aim for in the upcoming new simplytest.me, I had a quick look at just making composer dependencies work in a non fancy way for now.

My attached patch downloads composer_manager updates composer dependencies if the module being built has a composer.json.

Currently only works for building modules, not distributions. Not looked into distros yet.

patrickd’s picture

patrickd commented
Status: Needs review » Fixed

deployed, thanks yanniboy!!!

please open a new ticket if you still find to have issues regarding composer support, thanks!

  • patrickd committed 6a97636 on 7.x-1.x 
    Issue #2069833 by yanniboi: Added composer support with composer_manager...
  • patrickd committed e36c98e on 7.x-1.x
    Issue #2069833: Adding composer support.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.