Updated: Comment #0

Problem/Motivation

  1. \Drupal\node\NodeTypeAccessController uses user_access() which is deprecated.
  2. \Drupal\node\NodeTypeAccessController has no unit tests.

Proposed resolution

  1. Use $account->hasPermission() instead
  2. Tests, tests, tests, tests, tests!!!

Remaining tasks

Review patch.

#2041333: Inject the module handler into the entity access controller

CommentFileSizeAuthor
#4 2069291-4-node-type-access-controller.patch6.05 KBtstoeckler
#4 interdiff-1-4.txt997 byteststoeckler
#1 2069291-1-node-type-access-controller.patch5.76 KBtstoeckler

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2069291-1-node-type-access-controller.patch5.76 KB

Status: Needs review » Needs work

The last submitted patch, 2069291-1-node-type-access-controller.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Sub-class must implement the getInfo method!

Thanks bot, that's actually a useful hint. I forgot our weirdo PhpUnit usage.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1-4.txt997 bytes
new 2069291-4-node-type-access-controller.patch6.05 KB

Let's see if this works better.

alansaviolobo’s picture

alansaviolobo commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

the controller doesn't seem to exist anymore