Mark aggregator_save_category() as deprecated [#2068393]

so in #2046303: Convert aggregator_form_category to FormInterface we introduced swappable storage for aggregator categories, as an interim step, since converting them to terms, is clearly not gonna happen in D8.
But while we marked aggregator_category_load() as deprecated we forgot to do so for aggregator_save_category

Comment	File	Size	Author
#1	aggregator-category-storage-2068393.patch	14.93 KB	ParisLiakos
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ParisLiakos CreditAttribution: ParisLiakos commented 18 August 2013 at 20:17

Status:

Active

» Needs review

File	Size
aggregator-category-storage-2068393.patch	14.93 KB

Comment #2

ParisLiakos CreditAttribution: ParisLiakos commented 20 August 2013 at 03:53

about getting menu link and block things in the storage controller:
its far better to have them in once place together, than duplicating the logic (eg what we do now in form and CategoryAdminForm and CategoryDeleteForm)
and this place should either be aggregator_save_category() or the storage controller?

after a few discussion on irc, the best way would just be to make categories classed objects and put this logic in there..

Comment #3

dawehner

German

CreditAttribution: dawehner commented 20 August 2013 at 21:07

+++ b/core/modules/aggregator/lib/Drupal/aggregator/CategoryStorageController.php
@@ -98,4 +124,39 @@ public function isUnique($title, $cid = NULL) {
+    if (isset($op) && $this->moduleHandler->moduleExists('menu_link')) {
+      menu_link_maintain('aggregator', $op, $link_path, $title);
+    }

I am wondering whether it is the proper concept to update menu links like that. Maybe we can use something similar than on #2018493: Tests for: FATAL error when a view with a placed block is disabled or removed

Comment #4

ParisLiakos CreditAttribution: ParisLiakos commented 3 September 2013 at 04:24

after a few discussion on irc, the best way would just be to make categories classed objects and put this logic in there..

But then making them classed object means it should be an Entity, and if its Entity it should be Term...you can see us going back to #15266: Replace aggregator category system with taxonomy...so i am tempted to just remove this function all together