As part of #2061107: Remove deprecated procedural functions in Field API, to get a clearer view of the current status & content of field.module

- moves all deprecated functions to a field.deprecated.inc file. #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled mentions introducing this pattern more generally, possibly along with an automatic switch to load *deprecated files or not. Since all the functions involved here are currently unconditionally loaded anyway, I'd rather do the move now to facilitate the current cleanup work without waiting for that other issue.
- moves hook_entity_bundle_*() implementations out of field.crud.inc to the main module file
- renames field.crud.inc to field.purge.inc, since that is all there's left in there
- moves field_language_fallback() from field.module to field.multilingual.inc

Patch coming up after I get a node id.

CommentFileSizeAuthor
#11 field-reorganize_files-2067127-11.patch94.75 KByched
#9 field-reorganize_files-2067127-9.patch66.21 KByched
#7 field-reorganize_files-2067127-7.patch94.86 KByched
#5 field-reorganize_files-2067127-5.patch97.32 KByched
#5 interdiff.txt2.01 KByched
#1 field-reorganize_files-2067127-1.patch93.45 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
FileSize
field-reorganize_files-2067127-1.patch93.45 KB

Patch

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
yched’s picture

yched CreditAttribution: yched commented
Issue tags: +Field API

& tag...

Status: Needs review » Needs work

The last submitted patch, field-reorganize_files-2067127-1.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.01 KB
field-reorganize_files-2067127-5.patch97.32 KB

- Missing "use" statement
- _field_sort_items_value_helper() belongs to field.form.inc

amateescu’s picture

amateescu CreditAttribution: amateescu commented 
+++ b/core/core.services.yml
@@ -171,7 +171,7 @@ services:
-    arguments: ['@container.namespaces', '@controller_resolver', '@request', '@module_handler', '@cache.cache', '@language_manager']
+    arguments: ['@container.namespaces', '@controller_resolver', '@request', '@module_handler']

index c99dd83..f4aab24 100644
--- a/core/lib/Drupal/Core/Menu/LocalActionManager.php

--- a/core/lib/Drupal/Core/Menu/LocalActionManager.php
+++ b/core/lib/Drupal/Core/Menu/LocalActionManager.php

This looks unrelated :)

yched’s picture

yched CreditAttribution: yched commented
FileSize
field-reorganize_files-2067127-7.patch94.86 KB

Oops, indeed. Wrong merge in my local branch I guess...

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

The patch is impossible to follow but assuming it does what it says in the issue summary, I think it's a good cleanup step.

yched’s picture

yched CreditAttribution: yched commented
FileSize
field-reorganize_files-2067127-9.patch66.21 KB

Rerolled after #1847002: Move entity type classes from Drupal\$provider\Plugin\Core\Entity to Drupal\$provider\Entity

Status: Reviewed & tested by the community » Needs work

The last submitted patch, field-reorganize_files-2067127-9.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Reviewed & tested by the community
FileSize
field-reorganize_files-2067127-11.patch94.75 KB

Yeah, sorry, left one conflict unresolved.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

So I've reviewed this using a script to compare functions across two git checkouts - which I'll try and share sometime - there is no functional change here.

Committed 375a708 and pushed to 8.x. Thanks!

yched’s picture

yched CreditAttribution: yched commented

@alexpott: thanks! - and +1 to sharing that script on gist :-)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Mention #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled