Some of the formatter settings for fieldgroups get output even if their value is effectively none.

speed-none effect-none

The default effect should be no effect, we don't need a special classes to communicate this, I can't see how this would be used.

field-group-div

While I'm at it, having a class that describes the element seems redundant. Let's get rid of that to.

Comments

chrisjlee’s picture

Assigned: Unassigned » chrisjlee

+1

nils.destoop’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community

Setting it to reviewed and tested by the community. But this is just so that i know that this issue will be fixed when i can push to drupal.

The classes are not added when no effect is selected.
The field-group-div is already removable / removed in 1.x

nils.destoop’s picture

Status: Reviewed & tested by the community » Fixed

pushed to dev

dtarc’s picture

Status: Fixed » Active

We were using the .field-group-div selector heavily to style field groups from 1.1. We'd like to upgrade to 1.2 or at least a more recent version of 1.1 but the lack of .field-group-div breaks our theme.

How would I go about getting .field-group-div back? At this point it doesn't seem like there is any class being added to specify that an element is a field group.

dtarc’s picture

Status: Active » Fixed

I figured out what happened & created an issue regarding features support here #2085225: Featurized Field Groups no longer have classes since marked optional.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit d0b6c4e on 7.x-1.x, 8.x-1.x by zuuperman:
    Issue #2065827 by LewisNyman: Remove CSS classes that communicate the...