(this pertains to the "new" branch)

I'm building a custom puppet script that installs Drush 6 via the Puppet Drush module (using the Drush::Git::Drush class), and then installing Aegir 2 via this module.

This module, however, attempts to install Drush without first checking to see if it's already installed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m.stenta’s picture

Status: Active » Needs review
FileSize
969 bytes

Talked to @ergonlogic in IRC, and put together a patch for it.

ergonlogic’s picture

First off, thanks again!

Why did you put the file resource in the conditional block? This is essentially there to remove files (since deprecated) from the old puppet-drush module.

m.stenta’s picture

Ah, gotcha. I didn't know that's what those were for. Updated patch attached (I also included your description as a comment for others to help understand those lines).

ergonlogic’s picture

Status: Needs review » Fixed

fixed in 80661c5. Thanks again!

m.stenta’s picture

Status: Fixed » Needs work

Dang! I just realized that this doesn't work, because the lines that delete those deprecated files send a notification to "Exec['drush_update_apt']", which doesn't exist in this context (where Drush is already installed and we're not including drush here).

Should we just remove the notify => Exec['drush_update_apt'] line? Is it important to have?

ergonlogic’s picture

Status: Needs work » Fixed

fixed in bf54444 by changing to: notify => Exec['aegir_update_apt']

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.