PHP 5.2 compatibility (syntax error, unexpected T_STRING) [#2062849]

Below is the syntax error in the main recommended beta1 version, It is very serious because it halt the whole website and leave the module installation in the middle. I don't know what that means, but I comment it out and the installation completed, but other errors appear and display no form, no format, only text in admin curmbs settings page.

Parse error: syntax error, unexpected T_STRING, expecting T_CONSTANT_ENCAPSED_STRING or '(' in /sites/all/modules/crumbs/admin/crumbs.expansible.inc on line 3

Admin crumbs setting page errors

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /sites/all/modules/crumbs/lib/InjectedAPI/hookCrumbsPlugins.php on line 33

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /sites/all/modules/crumbs/lib/InjectedAPI/hookCrumbsPlugins.php on line 44

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /sites/all/modules/crumbs/lib/InjectedAPI/hookCrumbsPlugins.php on line 55

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /sites/all/modules/crumbs/lib/InjectedAPI/hookCrumbsPlugins.php on line 65

These are errors showing every where in website.

Notice: Undefined index: weight in crumbs_Admin_WeightsTable->addElement() (line 112 of /sites/all/modules/crumbs/lib/Admin/WeightsTable.php).
Notice: Undefined index: #crumbs_rule_info in crumbs_Admin_WeightsTable->addRow() (line 138 of /sites/all/modules/crumbs/lib/Admin/WeightsTable.php).
Notice: Undefined index: #title in crumbs_Admin_WeightsTable->addRow() (line 140 of /sites/all/modules/crumbs/lib/Admin/WeightsTable.php).
Notice: Trying to get property of non-object in crumbs_Admin_WeightsTable->rowAddMethodInfo() (line 160 of /sites/all/modules/crumbs/lib/Admin/WeightsTable.php).
Notice: Trying to get property of non-object in crumbs_Admin_WeightsTable->rowAddMethodInfo() (line 168 of /sites/all/modules/crumbs/lib/Admin/WeightsTable.php).

I had to disable the module.

Please note: these errors show for dev version as-well.

Comment	File	Size	Author
#8	ScreenCapture.JPG	76.9 KB	fhdrupal

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

donquixote CreditAttribution: donquixote commented 12 August 2013 at 00:38

This sounds serious. I am going to look into it in the next few hours.
I will probably need some feedback on the way, I appreciate if you can check your email every now and then :)

Are the line numbers from beta1 or from -dev?

Comment #2

donquixote CreditAttribution: donquixote commented 12 August 2013 at 00:41

Aaaaah, I think I know what is going on!
You are probably on PHP 5.2, and some of the new code is not PHP 5.2 proof.

E.g.

    throw new \Exception(..)

This only works in PHP 5.3+.

Solution:
Crumbs is made to be compatible with PHP 5.2, so we have to remove all the backslashes.
I am going to push a hotfix in the next few hours.
(but it can take some time for the packaging script to actually publish the new release)

Comment #3

donquixote CreditAttribution: donquixote commented 12 August 2013 at 00:42

@fhdrupal:
Since I don't have a PHP 5.2 available locally for testing, I appreciate a lot that you report these issues!

Comment #4

fhdrupal CreditAttribution: fhdrupal commented 12 August 2013 at 00:48

You are welcome, No problem, appreciate quick response. These errors shows for both versions.

Comment #5

donquixote CreditAttribution: donquixote commented 12 August 2013 at 01:01

I made a 7.x-2.x-hotfix branch.
Can you test with that?

Comment #6

donquixote CreditAttribution: donquixote commented 12 August 2013 at 01:05

Title:

syntax error, unexpected T_STRING

» PHP 5.2 compatibility (syntax error, unexpected T_STRING)

Comment #7

donquixote CreditAttribution: donquixote commented 12 August 2013 at 01:34

Status:

Active

» Fixed

Released as 7.x-2.0-beta2.
Please reopen if you notice further issues!

Comment #8

fhdrupal CreditAttribution: fhdrupal commented 12 August 2013 at 15:26

File	Size
ScreenCapture.JPG	76.9 KB

I upgraded my PHP to 5.3 version, thanks for reminding me, didn't noticed, beta1 version still had the same errors. Installed beta2 normally, but only textual labs comes on, tabledrag comes as only text no admin page with the following error.

Fatal error: Call to a member function getAll() on a non-object in /sites/all/modules/crumbs/lib/Admin/WeightsTable.php on line 154

Attached image below shows the error screen captured.

Comment #9

donquixote CreditAttribution: donquixote commented 12 August 2013 at 15:34

Can you look in your /var/log/apache2/error.log?
(or whatever error log you have)

And afterwards, can you see if clearing the cache does help?

Comment #10

donquixote CreditAttribution: donquixote commented 12 August 2013 at 15:34

Ah, that's probably where you saw the error you just posted?

Comment #11

donquixote CreditAttribution: donquixote commented 12 August 2013 at 15:39

Status:

Fixed

» Needs work

Can you check if the latest -dev from git has this fixed?

Comment #12

fhdrupal CreditAttribution: fhdrupal commented 12 August 2013 at 15:40

Status:

Needs work

» Fixed

I cleared the cache before new installation, Yes the error is just below the screen I attached.

Comment #13

fhdrupal CreditAttribution: fhdrupal commented 12 August 2013 at 16:02

The -dev posted today tabledrag work fine, but the textual version shows the following error, and empty screen.

Exception: Key adminPluginInfo not supported. in crumbs_Container_CachedLazyData->__get() (line 64 of /sites/all/modules/crumbs/lib/Container/CachedLazyData.php).
The website encountered an unexpected error. Please try again later.