derived from #2061921: Remove calls to deprecated global $user in views module

Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

All places in views plugin FilterPluginBase.php of the views module should be fixed with $request properly injected

core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php:

global $user;
CommentFileSizeAuthor
#5 2062261-5.patch2.4 KBalphawebgroup
#3 2062261-3.patch2.41 KBalphawebgroup
#1 2062261-1.patch2.41 KBalphawebgroup
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Active » Needs review
FileSize
2062261-1.patch2.41 KB

Status: Needs review » Needs work

The last submitted patch, 2062261-1.patch, failed testing.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs work » Needs review
FileSize
2062261-3.patch2.41 KB

just retesting

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

We should always use the curent_user service :(

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs work » Needs review
FileSize
2062261-5.patch2.4 KB
alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs review » Closed (duplicate)