Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Garbar’s picture

Status: Active » Needs review
FileSize
1.71 KB

need reviews

dawehner’s picture

Status: Needs review » Needs work

Thanks for your patch!

@@ -42,9 +42,9 @@ class ViewsBlock implements ContainerDerivativeInterface {
-  public static function create(ContainerInterface $container, $base_plugin_id) {
+  public static function create(ContainerInterface $container, $basePluginId) {
...
+      $basePluginId,

@@ -52,13 +52,13 @@ public static function create(ContainerInterface $container, $base_plugin_id) {
-   * @param string $base_plugin_id
+   * @param string $basePluginId
...
+  public function __construct($basePluginId, EntityStorageControllerInterface $view_storage_controller) {
+    $this->basePluginId = $basePluginId;

The property on the object should be $basePluginId (as you did it), but the method parameters should be $base_plugin_id.

undertext’s picture

Status: Needs work » Needs review
FileSize
543 bytes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This is fine!

alexpott’s picture

Category: task » bug
Status: Reviewed & tested by the community » Fixed

Committed 983bdab and pushed to 8.x. Thanks!

Reclassifying this to bug because it is.

Automatically closed -- issue fixed for 2 weeks with no activity.