I updated from 2.8 to 2.10 and the contextual links are not displaying on hover. I must be missing some wrapper or class but I'm not sure which. I unchecked a few options but to no avail such as "remove .view class"

This is happening for blocks and views pages.

Ideas?

CommentFileSizeAuthor
#4 mothership-contextual-links-fix-2061657-4.patch684 bytesdooleysarahe
#1 mothership-contextual-links-fix-2061657-1.patch684 bytesdooleysarahe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dooleysarahe’s picture

dooleysarahe CreditAttribution: dooleysarahe commented
Version: 7.x-2.10 » 7.x-2.x-dev
FileSize
mothership-contextual-links-fix-2061657-1.patch684 bytes

Looks like there was a change to the /modules/contextual/contextual.js that needs to be applied to /sites/all/themes/mothership/mothership/js/contextual.js. I've attempted to create a patch...

dooleysarahe’s picture

dooleysarahe CreditAttribution: dooleysarahe commented
Status: Active » Needs review
cduwe’s picture

cduwe CreditAttribution: cduwe commented

Yup. Your fix works although I got

patching file mothership/js/contextual.js
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file mothership/js/contextual.js.rej

when I tried to apply the patch.

Thanks
C-

dooleysarahe’s picture

dooleysarahe CreditAttribution: dooleysarahe commented
FileSize
mothership-contextual-links-fix-2061657-4.patch684 bytes

Hmm, OK--new to making patches. I was able to apply this one cleanly to a test branch--see if it works.

pyxio’s picture

pyxio CreditAttribution: pyxio commented

This works. Thanks much for making this patch. cheers

enzipher’s picture

enzipher CreditAttribution: enzipher commented

Confirming that the fix works. Thanks!

Cheers,

Screenack’s picture

Screenack CreditAttribution: Screenack commented

Also confirming patch here against 2.10

jive01’s picture

jive01 CreditAttribution: jive01 commented

It's not working for me.... here is my contextual.js file with the patch applied:

http://pastebin.com/TcE6cx4h

Screenack’s picture

Screenack CreditAttribution: Screenack commented
Issue summary: View changes

Jive01: I ran a diff on our patched contextual.js files there's no difference. Is Google Chrome's inspector throwing errors? BTW — let's take this discussion offline and we can follow up if we resolve it. Contact me via my profile page on d.o.

jive01’s picture

jive01 CreditAttribution: jive01 commented

Hello,

I was getting js errors. Resulting from this plugin: https://drupal.org/project/responsive_menus . I disabled that plugin and my contextual links are now showing. Thanks!

realityloop’s picture

realityloop
he/him
CreditAttribution: realityloop commented
Status: Needs review » Fixed

Fixed in 3.x, Overiding of contextual links css and JS is now optional in CSS Reset section of theme settings

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.