Currently flexslider_add() is called inside template_preprocess_flexslider(). This isn't good, because it's the first function to be invoked and doesn't give any other other modules or themes the chance to modify the variables before it's shipped off to add the necessary JS.

Files: 
CommentFileSizeAuthor
#2 flexslider-allow-themesmodule-2061499-2.patch1.05 KBmarkcarver
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#2 interdiff.txt723 bytesmarkcarver
#1 flexslider-allow-themesmodule-2061499-1.patch1.13 KBmarkcarver
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#1 interdiff.txt815 bytesmarkcarver

Comments

markcarver’s picture

Status:Active» Needs review
StatusFileSize
new815 bytes
new1.13 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Attaching patch

markcarver’s picture

StatusFileSize
new723 bytes
new1.05 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Ugh sorry, ran drush_iq from the wrong path. Here's the correct patch.

minorOffense’s picture

Status:Needs review» Closed (fixed)

Committed.

Thanks!

markcarver’s picture

Status:Closed (fixed)» Fixed

Appropriate status.

minorOffense’s picture

I've made changes to the preprocess flow. Most everything is now in the process hook. Should be fine but want to ensure I didn't create a regression issue.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.