Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm making a start on a D8 version of styleguide.
So far, just by changing the info file format and commenting out a couple of fatal errors, it works.
Obviously still needs work...
Known issues
- Fatal error if comment module is enabled: Fatal error: Call to undefined method stdClass::uri() in /var/www/html/drupal8/core/modules/comment/comment.module on line 1540
Comment | File | Size | Author |
---|
Comments
Comment #1
malcomio CreditAttribution: malcomio commentedupdated patch with fragment links fixed
Comment #1.0
malcomio CreditAttribution: malcomio commentedstarted known issues section
Comment #2
victor-shelepen CreditAttribution: victor-shelepen commentedIt is very interesting issue. I think D8 needs this. Let make a new branch for. My first modifications are. The common themes are rendered.
Comment #3
victor-shelepen CreditAttribution: victor-shelepen commentedHello. Let's create a sandbox elsewhere.
Comment #4
victor-shelepen CreditAttribution: victor-shelepen commentedI've created the sandbox for. https://drupal.org/sandbox/likin/2151701
Comment #5
chrisjlee CreditAttribution: chrisjlee commentedWhere is it?
Comment #6
victor-shelepen CreditAttribution: victor-shelepen commentedhttps://drupal.org/sandbox/likin/2151701
Comment #7
5n00py CreditAttribution: 5n00py commentedIts fully broken. Module have 35+ calls to theme(). So we need to replace them.
Comment #8
chrisjlee CreditAttribution: chrisjlee commentedShould we just start a new sandbox?
Comment #9
5n00py CreditAttribution: 5n00py commentedI think no, just work on existing sandbox.
Comment #10
markhalliwellNeed to identify which module this belongs to in the title for other related issue.
Comment #11
malcomio CreditAttribution: malcomio commentedProbably easier to use github for the moment - I've made a start at https://github.com/malcomio/styleguide
Comment #12
victor-shelepen CreditAttribution: victor-shelepen commentedI also contrinue with the sandbox mentioned above - https://www.drupal.org/sandbox/likin/2151701 - branch 8.x-2.x
Comment #13
victor-shelepen CreditAttribution: victor-shelepen commentedHello. I need a help with the project Styleguide D8. I have done the bone of the project. I have what to show. I need a person who will define if I proceed with the project.
https://www.drupal.org/sandbox/likin/2151701
https://docs.google.com/document/d/1F085GVrmQrkL4MBCMgFIoxJLeS6VHRjA1Ai-...
http://cgit.drupalcode.org/sandbox-likin-2151701
We can arrange a hangout meeting.
Regards, Viktor.
Comment #14
vijaycs85I have been working on this in github at https://github.com/vijaycs85/styleguide and happy to merge with @likin work at #13
Comment #15
tim.plunkettSo we have 3 competing ports. Are any of you looking to maintain the D8 branch in the future, or are you just porting it?
Comment #16
victor-shelepen CreditAttribution: victor-shelepen commentedI want to cooperate with. I hope I will be able to support. Now I have got free time so I proceed with. I asked for a help or directions, specifications. I have not received yet. I will be glad to get a maintainer.
Comment #17
malcomio CreditAttribution: malcomio commentedYes I'd be happy to maintain - Vijay and I work together, and he's more familiar with D8 than I am, so I suggest that we work on his repo for now: https://github.com/vijaycs85/styleguide
That way we can use github pull requests rather than passing patches around.
Once the module is nearer to being ready, then we can bring it back into drupal.org.
Comment #18
vijaycs85+1 to add @malcomio as co-maintainer.
yep and we can mirror push to drupal.org to keep the 8.x branch up to date.
Comment #19
victor-shelepen CreditAttribution: victor-shelepen commentedOk. I see. I continue my way. I think I will study the Drupal 8 idioms better and faster this way. Who wants follow on my way contact me. Regards.
Comment #20
vijaycs85@likin, I would suggest we all work on one version to port D8. I just had a look at your sandbox. It looks much better and cleaner than mine. e.g
- I have split item & group as two different plugins
- follow the same D7 long page.
You have created clear layout and a render to playaround which is great.
So let's leave my fork aside and push your changes to 8.x in this project and all share the work here please.
Comment #21
victor-shelepen CreditAttribution: victor-shelepen commented@vijaycs85 Ok. I agree with you. I realy want to be co-maintainer. I hope for your help and instructions.
Thank you.
Comment #22
dead_armIf we have reached consensus to use the sandbox that @likin started, that is fine. I can't add a maintainer, agentrickard will need to do that.
Comment #23
Adam Clarey CreditAttribution: Adam Clarey commentedI tried installing this today but it was incredibly buggy. I went through all the bugs that were preventing the page from loading properly and fixed them.
I've attached a patch of all the changes, some which are not pretty but at least its working now.
There are additional twig files that are in the zip in the correct directory.
It just needs further cleaning up
Comment #24
tannerjfco CreditAttribution: tannerjfco commentedstandardize title
Comment #25
andypostLooks everything is outdated, is there anyone who willing to maintain and finish d8 port?
Comment #26
dustinleblanc@andypost,
Singlebrook has interest in expanding and improving the styleguide module. I've not yet had the experience of maintaining a contributed module so I'm not entirely sure I'd be qualified for the task yet but I'd certainly be interested in contributing towards this work.
Comment #27
andypostAlso there's some work in https://www.drupal.org/project/kss
Comment #28
OleksiyI have started work on the module port. Nothing to attach now, I will create a patch when more or less working version will be available.
Comment #29
Sutharsan CreditAttribution: Sutharsan commented@Oleksiy, what is the status? I like to use (parts of) this module for a training course early next month. I can contribute.
Comment #30
OleksiyBasic functionality is almost done, need to fix themes switcher and do some code cleanup. I hope to show some results at the weekend.
Comment #31
OleksiyHave done basic functionality. Major things which still need to be done:
Patch attached. Also created repo on GiHub https://github.com/Shdulin/styleguide
Please review.
Comment #33
Sutharsan CreditAttribution: Sutharsan commentedContributed to @Olesksiy's github repo by converting the styleguide generator functions into a service: https://github.com/Shdulin/styleguide/pull/1
The basic styleguide page (admin/appearance/styleguide) works fine.
Comment #34
Sutharsan CreditAttribution: Sutharsan commentedHmm, No we have 4 competing ports (see #15). And no progress in more than 1 year. @dead_arm or @agentrickard can someone take a lead here? We are burning contributors :(
Comment #35
OleksiyI could try to maintain the D8 branch. But I never maintained any module before, so probably will need some advice.
Comment #36
vijaycs85I think most of them out dated. @likin's fork is the only fork that's valid until #20. Seems @Adam Clarey has some update.
@likin fork is bit different from D7 version (with more options and improvements) and last update was year ago(http://cgit.drupalcode.org/sandbox-likin-2151701/log/?h=8.x-2.x). So a) probably not up to date with core b) It can be released as separate project, if we have to in future.
IMHO, we can go ahead with @Oleksiy port. I have installed it and looks very close to D7.
Comment #37
Sutharsan CreditAttribution: Sutharsan commentedIf the module (co-)maintainer agrees to go forward with @Oleksiy's patch, and she/he can not mentor him, I can be his mentor in improving the port and maintaining the module.
Unassigning @malcomio (no activity in a year).
Comment #38
serg2 CreditAttribution: serg2 commentedHas anyone reach out to @agentrickard to ask if can add a new co-maintainer?
Comment #39
Sutharsan CreditAttribution: Sutharsan commentedI just left him a message in IRC.
Comment #40
agentrickard@dead_arm now has permission to edit module maintainers.
Comment #41
dead_armI've made @Oleksiy a co-maintainer, @Sutharsan let me know if you need any elevated permissions to help mentor.
Comment #42
Sutharsan CreditAttribution: Sutharsan commented@dead_arm, thank you. For now I will need no extra permission. I plan to work with @Oleksiy in his Github repo until we have a baseline D8 version (beta version?). I think that is where most of the mentoring will take place. If things will work out differently I will let you know.
Apart from that, not having permissions has benefits. I reduces my risk of co-maintaining another module ;)
Comment #43
Sutharsan CreditAttribution: Sutharsan commentedA small update: @Oleksiy is actively working on the issue in his github repo https://github.com/Shdulin/styleguide The module is working, more improvements to follow.
Comment #44
marcvangendI see that there is still work going on in the Github repository, the latest commit being from 18 days ago. Can someone give us an update on the status, perhaps an ETA, or a list of release blockers?
Comment #45
ressa CreditAttribution: ressa as a volunteer commentedI just tested the latest version from Github, and the only minor issue I could see is four warnings in the log:
Theme hook link not found.
.Aside from that it works perfectly, and looks ready for an official release here.
Comment #46
OleksiyI have added few fixes and have made first dev release.
D7 module things which are still missed from D8 module:
- aggregation module elements.
- book module elements.
- forum module elements.
- "Style guide palette" sub-module.
Also need to add support of new elements which were added in D8 core.
Thanks a lot to everyone who has helped us to make this module port.
Comment #47
andypostSuppose it makes sense to mark that issue fixed and roll out alpha release
Next issues could be filed separate
Comment #48
OleksiyThanks for support, Andy. Have created alpha release.
Comment #49
tim.plunkett