I'm making a start on a D8 version of styleguide.

So far, just by changing the info file format and commenting out a couple of fatal errors, it works.

Obviously still needs work...

Known issues

  • Fatal error if comment module is enabled: Fatal error: Call to undefined method stdClass::uri() in /var/www/html/drupal8/core/modules/comment/comment.module on line 1540
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

malcomio’s picture

FileSize
2.64 KB

updated patch with fragment links fixed

malcomio’s picture

Issue summary: View changes

started known issues section

victor-shelepen’s picture

It is very interesting issue. I think D8 needs this. Let make a new branch for. My first modifications are. The common themes are rendered.

victor-shelepen’s picture

Hello. Let's create a sandbox elsewhere.

victor-shelepen’s picture

I've created the sandbox for. https://drupal.org/sandbox/likin/2151701

chrisjlee’s picture

Where is it?

victor-shelepen’s picture

5n00py’s picture

Its fully broken. Module have 35+ calls to theme(). So we need to replace them.

chrisjlee’s picture

Should we just start a new sandbox?

5n00py’s picture

I think no, just work on existing sandbox.

markhalliwell’s picture

Title: Port to Drupal 8 » [styleguide] Port to Drupal 8
Related issues: +#2235485: [meta] Automated Theme Component Library - Overall concept/discussion

Need to identify which module this belongs to in the title for other related issue.

malcomio’s picture

Probably easier to use github for the moment - I've made a start at https://github.com/malcomio/styleguide

victor-shelepen’s picture

I also contrinue with the sandbox mentioned above - https://www.drupal.org/sandbox/likin/2151701 - branch 8.x-2.x

victor-shelepen’s picture

Hello. I need a help with the project Styleguide D8. I have done the bone of the project. I have what to show. I need a person who will define if I proceed with the project.
https://www.drupal.org/sandbox/likin/2151701
https://docs.google.com/document/d/1F085GVrmQrkL4MBCMgFIoxJLeS6VHRjA1Ai-...
http://cgit.drupalcode.org/sandbox-likin-2151701
We can arrange a hangout meeting.

Regards, Viktor.

vijaycs85’s picture

I have been working on this in github at https://github.com/vijaycs85/styleguide and happy to merge with @likin work at #13

tim.plunkett’s picture

So we have 3 competing ports. Are any of you looking to maintain the D8 branch in the future, or are you just porting it?

victor-shelepen’s picture

I want to cooperate with. I hope I will be able to support. Now I have got free time so I proceed with. I asked for a help or directions, specifications. I have not received yet. I will be glad to get a maintainer.

malcomio’s picture

Yes I'd be happy to maintain - Vijay and I work together, and he's more familiar with D8 than I am, so I suggest that we work on his repo for now: https://github.com/vijaycs85/styleguide

That way we can use github pull requests rather than passing patches around.

Once the module is nearer to being ready, then we can bring it back into drupal.org.

vijaycs85’s picture

+1 to add @malcomio as co-maintainer.

That way we can use github pull requests rather than passing patches around.

yep and we can mirror push to drupal.org to keep the 8.x branch up to date.

victor-shelepen’s picture

Ok. I see. I continue my way. I think I will study the Drupal 8 idioms better and faster this way. Who wants follow on my way contact me. Regards.

vijaycs85’s picture

@likin, I would suggest we all work on one version to port D8. I just had a look at your sandbox. It looks much better and cleaner than mine. e.g
- I have split item & group as two different plugins
- follow the same D7 long page.

You have created clear layout and a render to playaround which is great.

So let's leave my fork aside and push your changes to 8.x in this project and all share the work here please.

victor-shelepen’s picture

@vijaycs85 Ok. I agree with you. I realy want to be co-maintainer. I hope for your help and instructions.
Thank you.

dead_arm’s picture

If we have reached consensus to use the sandbox that @likin started, that is fine. I can't add a maintainer, agentrickard will need to do that.

Adam Clarey’s picture

FileSize
13.01 KB
605.73 KB

I tried installing this today but it was incredibly buggy. I went through all the bugs that were preventing the page from loading properly and fixed them.

I've attached a patch of all the changes, some which are not pretty but at least its working now.

There are additional twig files that are in the zip in the correct directory.

It just needs further cleaning up

tannerjfco’s picture

Title: [styleguide] Port to Drupal 8 » Port Style Guide module to Drupal 8

standardize title

andypost’s picture

Looks everything is outdated, is there anyone who willing to maintain and finish d8 port?

dustinleblanc’s picture

@andypost,

Singlebrook has interest in expanding and improving the styleguide module. I've not yet had the experience of maintaining a contributed module so I'm not entirely sure I'd be qualified for the task yet but I'd certainly be interested in contributing towards this work.

andypost’s picture

Also there's some work in https://www.drupal.org/project/kss

Oleksiy’s picture

I have started work on the module port. Nothing to attach now, I will create a patch when more or less working version will be available.

Sutharsan’s picture

@Oleksiy, what is the status? I like to use (parts of) this module for a training course early next month. I can contribute.

Oleksiy’s picture

Basic functionality is almost done, need to fix themes switcher and do some code cleanup. I hope to show some results at the weekend.

Oleksiy’s picture

Status: Active » Needs review
FileSize
69.07 KB

Have done basic functionality. Major things which still need to be done:

  1. cleanup StyleguideController and module
  2. port code in styleguide modules folder
  3. port styleguide_palette module

Patch attached. Also created repo on GiHub https://github.com/Shdulin/styleguide
Please review.

Status: Needs review » Needs work

The last submitted patch, 31: styleguide-d8_port-2061293-31.patch, failed testing.

Sutharsan’s picture

Contributed to @Olesksiy's github repo by converting the styleguide generator functions into a service: https://github.com/Shdulin/styleguide/pull/1

The basic styleguide page (admin/appearance/styleguide) works fine.

Sutharsan’s picture

Hmm, No we have 4 competing ports (see #15). And no progress in more than 1 year. @dead_arm or @agentrickard can someone take a lead here? We are burning contributors :(

Oleksiy’s picture

I could try to maintain the D8 branch. But I never maintained any module before, so probably will need some advice.

vijaycs85’s picture

I think most of them out dated. @likin's fork is the only fork that's valid until #20. Seems @Adam Clarey has some update.

@likin fork is bit different from D7 version (with more options and improvements) and last update was year ago(http://cgit.drupalcode.org/sandbox-likin-2151701/log/?h=8.x-2.x). So a) probably not up to date with core b) It can be released as separate project, if we have to in future.

IMHO, we can go ahead with @Oleksiy port. I have installed it and looks very close to D7.

Sutharsan’s picture

Assigned: malcomio » Unassigned

If the module (co-)maintainer agrees to go forward with @Oleksiy's patch, and she/he can not mentor him, I can be his mentor in improving the port and maintaining the module.

Unassigning @malcomio (no activity in a year).

serg2’s picture

Has anyone reach out to @agentrickard to ask if can add a new co-maintainer?

Sutharsan’s picture

I just left him a message in IRC.

agentrickard’s picture

@dead_arm now has permission to edit module maintainers.

dead_arm’s picture

I've made @Oleksiy a co-maintainer, @Sutharsan let me know if you need any elevated permissions to help mentor.

Sutharsan’s picture

@dead_arm, thank you. For now I will need no extra permission. I plan to work with @Oleksiy in his Github repo until we have a baseline D8 version (beta version?). I think that is where most of the mentoring will take place. If things will work out differently I will let you know.

Apart from that, not having permissions has benefits. I reduces my risk of co-maintaining another module ;)

Sutharsan’s picture

A small update: @Oleksiy is actively working on the issue in his github repo https://github.com/Shdulin/styleguide The module is working, more improvements to follow.

marcvangend’s picture

I see that there is still work going on in the Github repository, the latest commit being from 18 days ago. Can someone give us an update on the status, perhaps an ETA, or a list of release blockers?

ressa’s picture

Status: Needs work » Needs review

I just tested the latest version from Github, and the only minor issue I could see is four warnings in the log: Theme hook link not found..

Aside from that it works perfectly, and looks ready for an official release here.

Oleksiy’s picture

I have added few fixes and have made first dev release.

D7 module things which are still missed from D8 module:
- aggregation module elements.
- book module elements.
- forum module elements.
- "Style guide palette" sub-module.

Also need to add support of new elements which were added in D8 core.

Thanks a lot to everyone who has helped us to make this module port.

andypost’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev

Suppose it makes sense to mark that issue fixed and roll out alpha release
Next issues could be filed separate

Oleksiy’s picture

Status: Needs review » Closed (fixed)

Thanks for support, Andy. Have created alpha release.

tim.plunkett’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.