Hi,

Homebox is exporting homeboxes in arrays, and the arrays are defined thus:

      'gateway_user_topic_block' => array ( 
        'module' => 'gateway_user',
        'delta' => 'topic_block',
        'region' => 1,
        'movable' => 1,
        'status' => 1,
        'open' => 1,
        'closable' => 1,
        'title' => '',
        'weight' => -36,
      ),

There is a space between 'array' and '(' but the coding standards (https://drupal.org/coding-standards#array) show there should not be a space. This is picked up by coder_review.

Also, is there a reason the module doesn't use features_var_export()?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samhassell’s picture

Status: Active » Needs review
FileSize
844 bytes

Here's a patch that fixes this with a couple of preg_replace() calls.

drumm’s picture

Title: Array coding standards with homebox exportables » Make homebox exportables more standard
Issue summary: View changes
Status: Needs review » Needs work

Rather than niggling with homebox's custom export, I'd like to see this move to something more common, like ctools-based.

NerOcrO’s picture

This is my patch, with Feature's function.
Please review :)
Thx

NerOcrO’s picture

Status: Needs work » Needs review

  • drumm committed 8a82907 on 7.x-2.x authored by NerOcrO
    Issue #2058421: Make homebox exportables more standard
    
drumm’s picture

Status: Needs review » Fixed

Looks good, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.