Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Homebox is exporting homeboxes in arrays, and the arrays are defined thus:
'gateway_user_topic_block' => array (
'module' => 'gateway_user',
'delta' => 'topic_block',
'region' => 1,
'movable' => 1,
'status' => 1,
'open' => 1,
'closable' => 1,
'title' => '',
'weight' => -36,
),
There is a space between 'array' and '(' but the coding standards (https://drupal.org/coding-standards#array) show there should not be a space. This is picked up by coder_review.
Also, is there a reason the module doesn't use features_var_export()?
Comment | File | Size | Author |
---|---|---|---|
#3 | homebox-exportable-array-coding-standard-2058421-2.patch | 509 bytes | NerOcrO |
#1 | homebox-exportable-array-coding-standard-2058421-1.patch | 844 bytes | samhassell |
Comments
Comment #1
samhassell CreditAttribution: samhassell commentedHere's a patch that fixes this with a couple of preg_replace() calls.
Comment #2
drummRather than niggling with homebox's custom export, I'd like to see this move to something more common, like ctools-based.
Comment #3
NerOcrO CreditAttribution: NerOcrO commentedThis is my patch, with Feature's function.
Please review :)
Thx
Comment #4
NerOcrO CreditAttribution: NerOcrO commentedComment #6
drummLooks good, committed.