What the title says.

Makes much more sense in drush than UI IMHO, then it's just another command after a git pull.

CommentFileSizeAuthor
#9 new_relic_drush_command-d8.patch2.35 KBneclimdul
#7 2058183-7-new_relic_rpm-drush_deploy.patch2.34 KBramlev
#7 interdiff.txt2.85 KBramlev
#6 2058183-6-new_relic_rpm-drush_deploy.patch2.3 KBneclimdul
#6 interdiff.txt670 bytesneclimdul
#5 2058183-5-new_relic_rpm-drush_deploy.patch2.47 KBneclimdul
#2 2058183-3-new_relic_rpm-drush_deploy.patch2.31 KBneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker commented

Cool idea! Would help a lot to set a deploy marker this way.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
FileSize
2058183-3-new_relic_rpm-drush_deploy.patch2.31 KB

Agreed, would be able to take the hard coded curl's out of my deploy scripts. ;)

Wrote a quick implementation in D6. Should be a simple port if it doesn't apply to D7.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker commented
Status: Active » Needs work 
+++ b/new_relic_rpm.drush.incundefined
@@ -15,3 +15,36 @@ function new_relic_rpm_drush_init() {
+    // a short description of your command
...
+      'user' => dt('Optional. User doing the deploy'),
+      'description' => dt('Optional. A text annotation or description describing the deployment'),
+      'changelog' => dt('Optional. A list of changes for this deployment'),
+      'revision' => dt('Optional. Revision id of the deployment'),

I guess it should all end with a ".".

+++ b/new_relic_rpm.moduleundefined
@@ -241,11 +241,18 @@ function new_relic_rpm_module_deploy($new_modules, $disable_modules) {
+function _new_relic_rpm_deploy($user = NULL, $description = NULL, $changelog = NULL, $revision = NULL) {

The function lacks description of @param's.
https://drupal.org/coding-standards/docs#param

Rest fine.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented 
+++ b/new_relic_rpm.drush.incundefined
@@ -15,3 +15,36 @@ function new_relic_rpm_drush_init() {
+
+/**
+ * Implements hook_drush_help().
+ */
+function new_relic_rpm_drush_help($section) {
+  switch ($section) {
+    case 'drush:newrelic-deploy':
+      return dt('Notify New Relic of a deployment.');

Pretty sure that this isn't necessary. drush help newrelic-deploy works just fine for me, including a description of the args without this.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
FileSize
2058183-5-new_relic_rpm-drush_deploy.patch2.47 KB

@miro_dietiker
Yeah I just hacked that old internal method real quick. Here's some documentation for it and those cleanups.

@Berdir
Hm... that must be an old API I pulled out of my boiler plate. Doesn't seem documented anymore, thanks.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
FileSize
interdiff.txt670 bytes
2058183-6-new_relic_rpm-drush_deploy.patch2.3 KB

removed some more boilerplate/api docs.

ramlev’s picture

ramlev CreditAttribution: ramlev commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.85 KB
2058183-7-new_relic_rpm-drush_deploy.patch2.34 KB

I have added a drush command alias (nrd) and fixed the patch to work with newest updates to the 7.x branch.

JordanMagnuson’s picture

JordanMagnuson CreditAttribution: JordanMagnuson commented
Issue summary: View changes

Love this idea. Is there a reason this has not been committed yet?

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
FileSize
new_relic_drush_command-d8.patch2.35 KB

Not sure how this needs to get committed. Here's the Drupal 8 version though.

  • Berdir committed b7a73ed on 7.x-1.x authored by neclimdul 
    Issue #2058183 by neclimdul, ramlev: Add drush command to create...
  • Berdir committed b5e79ba on authored by neclimdul
    Issue #2058183 by neclimdul, ramlev: Add drush command to create...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Well, you're a committer, so you could just commit it :)

Committed to 8.x-1.x and 7.x-1.x. Time to close this ;)

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented

Lol I forgot about this. I think at the time you where doing some work in github maybe and didn't want to conflict? Either way thanks for following up!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

JordanMagnuson’s picture

JordanMagnuson CreditAttribution: JordanMagnuson commented

This drush command doesn't seem to be working for me... no deployments are actually created on New Relic (though if I use the new relic module web interface to create a deployment, it works fine). Anyone else having this issue?