Buttons should be treated as Components instead of Base elements [#2058079]

According to the SMACSS and CSS architecture guidelines to Drupal 8, I think that buttons should be included in components/misc/buttons or components/buttons instead of base/buttons.

1) Base
Base rules consist of styling for HTML elements only, such as used in a CSS reset or Normalize.css. Base rules should never include class selectors.

(...)

3. Component (SMACSS “module”)
Reusable, discrete UI elements; components should form the bulk of Drupal’s CSS.

Source:
https://drupal.org/node/1887918
http://smacss.com/book/type-base
http://smacss.com/book/type-module

Thanks.

Comment	File	Size	Author
#7	omega-ohm-buttons-as-components-2058079-1.patch	929 bytes	brunorios1
#3	omega-ohm-buttons-as-components-2058079.patch	4.97 KB	brunorios1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fubhy CreditAttribution: fubhy commented 5 August 2013 at 16:18

I agree. Can you provide a patch? Will get you commit credit if you fancy that... Otherwise going to assign to @splatio as Ohm is his baby.

File	Size
omega-ohm-buttons-as-components-2058079.patch	4.97 KB

Comment #4

fubhy CreditAttribution: fubhy commented 5 August 2013 at 18:22

Status:

Active

» Needs work

Thanks! Can you do the diff by writing

git diff origin/7.x-4.x -M

That will make it easier to review as it recognizes moved files! Thanks!

Comment #5

brunorios1 CreditAttribution: brunorios1 commented 5 August 2013 at 18:28

i forgot to compile the scss to css too.
I'll work on this.

Comment #6

fubhy CreditAttribution: fubhy commented 5 August 2013 at 18:39

No, please don't compile the CSS. I will do that. That way we can maintain a clean commit history. :) (no compiled stuff in the same commit as the source).

File	Size
omega-ohm-buttons-as-components-2058079-1.patch	929 bytes

Comment #8

fubhy CreditAttribution: fubhy commented 5 August 2013 at 19:42

Perfect. Small and easy to review :). Do you want to get commit credit for this? (Yes you want)

If so, please properly configure your drupal.org account so that I can attribute you.

Please go here and configure your d.o account properly:

https://drupal.org/user/659648/edit/git

If you don't want that and just want to be mentioned in the git log then just reply here and I'll do that instead. However, note that that won't give you commit credit and won't list "Omega" as a project you contributed to in your drupal.org profile.

Comment #9

brunorios1 CreditAttribution: brunorios1 commented 5 August 2013 at 21:46

(Yes I want!)

I enabled the git access.
The e-mail configured in my machine was already the same as in drupal.org.
The name was not configured in my machine, i just configured to a friendly name.

So, i'll have to create the patch again to show my user.name in the repository?

Thanks for the support!