Patch follows ....

CommentFileSizeAuthor
#10 Missing-title-attributes-for-6.x-2057409-10.patch1.03 KBJosefFriedrich
#6 Missing-title-attributes-2057409-6.patch991 bytesJosefFriedrich
#1 Missing-title-attributes-2057409-2.patch1.36 KBJosefFriedrich
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JosefFriedrich’s picture

JosefFriedrich CreditAttribution: JosefFriedrich commented
FileSize
Missing-title-attributes-2057409-2.patch1.36 KB
ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented
Status: Active » Needs review
ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented

What's the rationale for changing ">>" to "»"?

Status: Needs review » Needs work

The last submitted patch, Missing-title-attributes-2057409-2.patch, failed testing.

JosefFriedrich’s picture

JosefFriedrich CreditAttribution: JosefFriedrich commented
Status: Needs work » Needs review

Most drupal pagers uses "»". In my opinion "»" looks nicer.

JosefFriedrich’s picture

JosefFriedrich CreditAttribution: JosefFriedrich commented
FileSize
Missing-title-attributes-2057409-6.patch991 bytes

Patch without changing ">>" to "»"

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented

Regarding the ">>": if you feel strongly about this, please open a feature request and supply a patch (the tests will need to be fixed in such patch as well). Let's keep this issue to strictly fixing the title attributes, which will increase the chance it is committed substantially.

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented
Status: Needs review » Reviewed & tested by the community

I applied this and the title attributes are now being added properly. Thanks for the patch!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to 7.x-2.x and 7.x-1.x, thanks. I think this also needs to be fixed in 6.x or was the API different there?

JosefFriedrich’s picture

JosefFriedrich CreditAttribution: JosefFriedrich commented
FileSize
Missing-title-attributes-for-6.x-2057409-10.patch1.03 KB

You are right. It should fixed in 6.x-2.x:
https://api.drupal.org/api/drupal/includes%21common.inc/function/l/6

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented
Status: Patch (to be ported) » Needs review
oadaeh’s picture

oadaeh CreditAttribution: oadaeh as a volunteer commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

This issue is being closed because it is against a branch for a version of Drupal that is no longer supported.
If you feel that this issue is still valid, feel free to re-open and update it (and any possible patch) to work with the 7.x-1.x branch (bug fixes only) or the 7.x-2.x branch.
Thank you.