As #2049159: Create a ControllerBase class to stop the boilerplate code madness showed you want at least for the moment both support ->generate() as well as ->generateFromPath()
which can't be typehinted with a single interface.

CommentFileSizeAuthor
#1 drupal-2057215-1.patch731 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
731 bytes
Crell’s picture

Status: Needs review » Reviewed & tested by the community

Yeah, let's.

pwolanin’s picture

Status: Reviewed & tested by the community » Needs review

duplicate/overlaps the work at: #2057155: Add a generateFromRoute() method on the url generator to accept options like url()

can we just get that in instead?

dawehner’s picture

The other patch will need discussion, this one, is already finished and unblocks #2049159: Create a ControllerBase class to stop the boilerplate code madness

Crell’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Yes, let's just do the easy thing on its own.

webchick’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

In the past few hours, #2049159 got committed (so this apparently didn't block it), and #2057155 is RTBC (and includes this patch, so committing this means a re-roll of that one which is 37K+). So I think I'm going to mark this one as a dupe. If that's the wrong course of action, feel free to re-open.

tim.plunkett’s picture

The ControllerBase issue now has method calls that violate the interface (because of this not being in).
Also it'd be trivial to reroll #2057155: Add a generateFromRoute() method on the url generator to accept options like url() on top, but if you just go commit that one instead it won't matter :)

dawehner’s picture

You know there is a reason why I filled this issue. Rerolling these days is simple as well as getting a review, as the routing system cleanup has sort of a team now.