Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As #2049159: Create a ControllerBase class to stop the boilerplate code madness showed you want at least for the moment both support ->generate() as well as ->generateFromPath()
which can't be typehinted with a single interface.
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal-2057215-1.patch | 731 bytes | dawehner |
Comments
Comment #1
dawehnerComment #2
Crell CreditAttribution: Crell commentedYeah, let's.
Comment #3
pwolanin CreditAttribution: pwolanin commentedduplicate/overlaps the work at: #2057155: Add a generateFromRoute() method on the url generator to accept options like url()
can we just get that in instead?
Comment #4
dawehnerThe other patch will need discussion, this one, is already finished and unblocks #2049159: Create a ControllerBase class to stop the boilerplate code madness
Comment #5
Crell CreditAttribution: Crell commentedYes, let's just do the easy thing on its own.
Comment #6
webchickIn the past few hours, #2049159 got committed (so this apparently didn't block it), and #2057155 is RTBC (and includes this patch, so committing this means a re-roll of that one which is 37K+). So I think I'm going to mark this one as a dupe. If that's the wrong course of action, feel free to re-open.
Comment #7
tim.plunkettThe ControllerBase issue now has method calls that violate the interface (because of this not being in).
Also it'd be trivial to reroll #2057155: Add a generateFromRoute() method on the url generator to accept options like url() on top, but if you just go commit that one instead it won't matter :)
Comment #8
dawehnerYou know there is a reason why I filled this issue. Rerolling these days is simple as well as getting a review, as the routing system cleanup has sort of a team now.