Files: 
CommentFileSizeAuthor
#7 vdc-2057207-7-FAIL.patch1.22 KBolli
FAILED: [[SimpleTest]]: [MySQL] 58,113 pass(es), 1 fail(s), and 0 exception(s). View
#7 interdiff-2057207-5-7.txt1.31 KBolli
#7 vdc-2057207-7.patch2.27 KBolli
PASSED: [[SimpleTest]]: [MySQL] 58,463 pass(es). View
#5 vdc-2057207-PASS.patch1.97 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,524 pass(es), 1 fail(s), and 1 exception(s). View
#4 vdc-2057207-FAIL.patch940 bytesdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,083 pass(es), 1 fail(s), and 1 exception(s). View
#4 vdc-2057207-PASS.patch940 bytesdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,563 pass(es), 1 fail(s), and 1 exception(s). View
#2 before.png13.57 KBolli
#2 after.png14.33 KBolli
#1 drupal-2057207-1.patch1.06 KBolli
PASSED: [[SimpleTest]]: [MySQL] 57,523 pass(es). View

Comments

olli’s picture

Status: Active » Needs review
Issue tags: +VDC
FileSize
1.06 KB
PASSED: [[SimpleTest]]: [MySQL] 57,523 pass(es). View
olli’s picture

FileSize
14.33 KB
13.57 KB
dawehner’s picture

Priority: Normal » Major
Issue tags: +Needs tests

Especially for the entity row plugin this is major!

Thanks for finding this problem!

dawehner’s picture

FileSize
940 bytes
FAILED: [[SimpleTest]]: [MySQL] 58,563 pass(es), 1 fail(s), and 1 exception(s). View
940 bytes
FAILED: [[SimpleTest]]: [MySQL] 58,083 pass(es), 1 fail(s), and 1 exception(s). View

Added a test.

dawehner’s picture

FileSize
1.97 KB
FAILED: [[SimpleTest]]: [MySQL] 58,524 pass(es), 1 fail(s), and 1 exception(s). View

Here is the one which actually should pass.

Status: Needs review » Needs work

The last submitted patch, vdc-2057207-PASS.patch, failed testing.

olli’s picture

Status: Needs work » Needs review
FileSize
2.27 KB
PASSED: [[SimpleTest]]: [MySQL] 58,463 pass(es). View
1.31 KB
1.22 KB
FAILED: [[SimpleTest]]: [MySQL] 58,113 pass(es), 1 fail(s), and 0 exception(s). View

Maybe this works.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Ha, never trust me :)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.