Postponed until 8.1.x is open for development.

Problem/Motivation

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it improves DX
Issue priority It is not major because it is something people have to get along anyway. There is no way that people just remember the service IDs
Disruption Changing any service NAME breaks contrib modules.
On top of it, this requires a lot of changes all over the place in core.

--------------------

Follow up for #1943846: Improve ParamConverterManager and developer experience for ParamConverters

Problem/Motivation

There is no standard for naming services.

Proposed resolution

Come up with standards around service name and update core code base and document accordingly.

Remaining tasks

Discuss
Write standards
Update documents.

User interface changes

No

API changes

No

Original report by @damiankloip

#1943846-112: Improve ParamConverterManager and developer experience for ParamConverters

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Linking a related issue: #2057869: Provide an alias for 'plugin.manager.entity' called 'entity.manager'

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Component: routing system » base system
Priority: Critical » Major
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Related: #1981368: Convert all routes to 'module_name.foo_bar' naming convention

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: standardize service name » [policy, then patch] Standardize service names
Issue tags: +Coding standards

I'm standardizing the issue title and tags for this issue. ;)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

So let's use $module.$servicename but skip the $module for the core.services.yml file?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

How about core.$servicename for those core.services.yml services? Then the pattern could be that if the file is called foo.services.yml the service is called foo.something? Just a thought...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

core.services.yml should use the subsystem/component.
In fact, we do that in most places:

entity.query, entity.manager
router, router.dumper, router.builder
config.storage, config.factory, config.context
route_enhancer.entity, route_enhancer.form, route_enhancer.authentication

Having core.entity.query is overkill.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Hm. entity.query... we have a module called entity, so wouldn't that clash with the modulename.whatever idea? Are there other possible clashes? It seems like this example negates what you are saying about overkill, at least possibly, because I think that we have "subsystems" that are named the same as core (or contrib?) modules.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

entity.module will be renamed entity_ui, AFAIK. We are doing the same for menu and action.

Crell’s picture

Crell CreditAttribution: Crell commented

I agree that for services they should be namespaced by the system, generally, not the module. In some cases the module is the subsystem (book.manager, etc.), which is fine, but adding core.* to everything in core.services.yml doesn't clarify anything and mostly just makes it more confusing. (Plus, that would require a ton of work to do right now and we've got enough tons of work already.)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It also seems odd for plugins as example, do we really want to have views.plugin.manager.field?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes

Postponed until 8.1.x is open for development.

Problem/Motivation

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it improves DX
Issue priority It is not major because it is something people have to get along anyway. There is no way that people just remember the service IDs
Disruption Changing any service NAME breaks contrib modules.
On top of it, this requires a lot of changes all over the place in core.
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 8.0.x-dev » 8.1.x-dev

moving.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald as a volunteer commented

Should this be postponed to 9.x for BC reasons?

Crell’s picture

Crell CreditAttribution: Crell as a volunteer commented

We could still alias names in D8, and drop the old names for D9. Assuming anyone still cares about the service names... :-)

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.