When a picture doesn't have a specific mapped exif_field, a notice shows:

Notice: Undefined index: EXIF:IFD0:ImageDescription in exif_custom_process_entity() (Line 454 of ****/www/sites/all/modules/exif_custom/exif_custom.module).

Line 454 of exif_custom.module:

$array['und']['0']['value'] = $data[$values->exif_field];

A workaround is to check if the value exists first:

if(isset($data[$values->exif_field])){
  $array['und']['0']['value'] = $data[$values->exif_field];
}
else{
  $array['und']['0']['value'] = NULL;
}
CommentFileSizeAuthor
#8 exif_custom-n2055529-8.patch563 bytesDamienMcKenna
#4 exif_custom-fix_undefined_index-2055529-3.patch1.35 KBsazcurrain
#1 exif_custom_2055529.patch613 bytesgaele
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gaele’s picture

gaele CreditAttribution: gaele commented
Priority: Normal » Major
Status: Active » Needs review
FileSize
exif_custom_2055529.patch613 bytes

Thanks Kim Kahns. Here's the patch based on the suggestion above.

edwbaker’s picture

edwbaker CreditAttribution: edwbaker commented
Issue summary: View changes
Status: Needs review » Fixed

Thanks! In 7.x-1.x branch for next release.

sazcurrain’s picture

sazcurrain CreditAttribution: sazcurrain commented

Hi,

The problem reported isn't fully solved. The previous patch only fixes the default option in a switch-case statement, based in the type of the mapped property.

When testing the mapping to a taxonomy term, you get the following messge:

Notice: Undefined index: IPTC:2#025 in exif_custom_process_entity() (line 413 from ***/sites/default/modules/contrib/exif_custom/exif_custom.module).

Here is a patch to fix the problem, using the same workarround from the previous patch.

sazcurrain’s picture

sazcurrain CreditAttribution: sazcurrain commented
FileSize
exif_custom-fix_undefined_index-2055529-3.patch1.35 KB
gaele’s picture

gaele CreditAttribution: gaele commented

Hi sazcurrain, you'd better open a new issue for this patch. This issue has status "Fixed".

edwbaker’s picture

edwbaker CreditAttribution: edwbaker commented
Status: Fixed » Needs review

Changed to needs review.

Status: Needs review » Needs work

The last submitted patch, 4: exif_custom-fix_undefined_index-2055529-3.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
exif_custom-n2055529-8.patch563 bytes

The patch in #4 needed to be rewritten to adhere to the Drupal coding standards.

I reviewed the code and I think the correct approach might be to skip processing the field if the EXIF value doesn't exist for that file.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Closed a duplicate: #2184359: Notice: Undefined index: *** in exif_custom_process_entity() (line 413 from ***modules/exif_custom/exif_custom.module).

recrit’s picture

recrit CreditAttribution: recrit commented
Status: Needs review » Reviewed & tested by the community

The #8 patch fixed the issue for me.

edwbaker’s picture

edwbaker CreditAttribution: edwbaker commented
Status: Reviewed & tested by the community » Closed (fixed)

Patch applied, will be in the next release.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Closed (fixed) » Reviewed & tested by the community

@edwbaker: I couldn't see where in the commit log this patch was committed? The current codebase looks like it'd still have this problem.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Fixed

Thanks DamienMckenna

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.