For: #2050477: [META] Identify component maintainers for components with no maintainer listed in MAINTAINERS.txt

Since jesse pretty much rewrote the module and I'd like to keep an eye on the toolbar JS.

I'll let jesse RTBC this one :)

#16 2054499-16.patch399 bytesxjm
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,620 pass(es). View
core-toolbar-maintainer.patch460 bytesnod_
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch core-toolbar-maintainer.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more


xjm’s picture

@nod_, did you talk to Jesse about this? I asked her two weeks ago and she said she preferred to not be in MAINTAINERS.txt for Toolbar, and that she hoped we could recruit someone who's not in MAINTAINERS.txt for anything else yet.

nod_’s picture

havent' talked about it with her. It just makes sense, she's the one who actually know everything there is to know about the toolbar. It's not like she has to answer all toolbar issues, at least people will know who has the knowledge for it.

xjm’s picture

Right, but being a component maintainer has a set of responsibilities associated with it:
#2050451: Formalize the role of core component maintainers

So it's entirely reasonable for someone who has deep knowledge in an area to choose not to be listed. :)

jessebeach’s picture

I am willing to take on maintainership after we've allowed a little time for others to consider volunteering (or being volunteered) for the role. Ideally we should have few duplicate names in MAINTAINERS.txt. This is a great opportunity for someone in the community to deepen their involvement in core.

xjm’s picture

Title: Add jessebeach and nod_ as toolbar maintainers » Add toolbar maintainers

Re-scoping per #4. :)

nod_’s picture

Works for me, I'm doubtful we'll get anyone new but happy to be proven wrong.

humansky’s picture

I've always wanted to contribute to core but feel I'm not quite ready yet but willing to help in anyway I can. Is this something a relative new Drupaler, yet seasoned PHPer, can take on?

dcmouyard’s picture

I'm inspired by Jesse's blog post, so I'm willing to maintain the toolbox module.

markcarver’s picture

I'm not yet deeply involved with Toolbar, but I'm certainly interested. Applying :)

Sam152’s picture

I haven't had a chance to go through any of the issues just yet, but if everyone else falls through, I would be happy to take on some of the responsibility.

njmahesh’s picture

I am definitely interested in taking the maintainer role for Drupal Core Toolbar.

xjm’s picture

Wow, awesome to see so many great responses! For those who haven't seen it yet, here's @jessebeach's post:

Toolbar involves some pretty heavy-duty JavaScript, so I'd recommend it especially for anyone who has JS skill (which is definitely not me). You don't have to be an expert, though, because both @jessebeach and @nod_ (our JavaScript maintainers) will help you along the way. :) The component maintainer responsibilities (in general) are described at:

@humansky, if you're relatively new to Drupal, I suggest you join us for core contribution mentoring this coming week:
We can help ramp you up with some of the Drupal issue queue skills that will help for Toolbar (or any core component).

@njmahesh, I think you also contacted me about Taxonomy? I'll follow up with you directly soon. :)

So, the next step for anyone interested in Toolbar in particular is to start working in the queue, doing the tasks @jessebeach describes in her post. :) For anyone who just wants to help out any way they can, I'd also suggest taking a look at #2050477: [META] Identify component maintainers for components with no maintainer listed in MAINTAINERS.txt -- there are lots of core modules that need a maintainer.

markcarver’s picture

Actually considering my involvement with the theme system/twig and now color.module, I think I'll be busy for now. I'll peak in from time to time to help when I can though.

jessebeach’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

On y va.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, core-toolbar-maintainer.patch, failed testing.

xjm’s picture

Status: Needs work » Reviewed & tested by the community
399 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,620 pass(es). View

Oops. :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 2054499-16.patch, failed testing.

jessebeach’s picture

Status: Needs work » Needs review

16: 2054499-16.patch queued for re-testing.

xjm’s picture

Status: Needs review » Reviewed & tested by the community

That fail is really starting to get to me.

  • Commit ec5aab4 on 8.x by alexpott:
    Issue #2054499 by xjm, nod_: Add toolbar maintainers.
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ec5aab4 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.