Add term link shouldn't appear when reset to alphabetical [#2053505]

When the user reset the vocab terms to alphabetical order the "Add term" link still appear.

Steps to reproduce:
Create a vocab
Add two terms
Reset the vocab terms to alphabetical
You should see the Add term link

Comment	File	Size	Author
#14	2053505-14-d8.png	29.78 KB	idebr
#11	add-tem-not-when-reset-alphabetical-d8-2053505-11.patch	5.93 KB	RoySegall
#11
#11	inner-diff.txt	558 bytes	RoySegall
#10	add-tem-not-when-reset-alphabetical-d8-2053505-10.patch	5.39 KB	RoySegall
#10
#8	add-tem-not-when-reset-alphabetical-d7-2053505-6.patch	5.33 KB	RoySegall
#8
#6	add-tem-not-when-reset-alphabetical-d8-2053505-6.patch	530.96 KB	RoySegall
#6
#6	add-tem-not-when-reset-alphabetical-d7-2053505-6.patch	5.33 KB	RoySegall
#6
#3	add-tem-not-when-reset-alphabetical-d7-2053505-3.patch	4.13 KB	RoySegall
#3
#3	add-tem-not-when-reset-alphabetical-d8-2053505-3.patch	4.46 KB	RoySegall
#3
#1	d8-reset-term.png	89.27 KB	RoySegall
	reset-alphabetical.png	72.12 KB	RoySegall

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

RoySegall CreditAttribution: RoySegall commented 30 July 2013 at 13:19

Version:

7.x-dev

» 8.x-dev

File	Size
d8-reset-term.png	89.27 KB

Also appear in Drupal 8 - change the version of the issue.

Comment #2

RoySegall CreditAttribution: RoySegall commented 30 July 2013 at 14:46

I'll supply a patch later on.

Comment #3

RoySegall CreditAttribution: RoySegall commented 30 July 2013 at 15:06

File	Size
add-tem-not-when-reset-alphabetical-d8-2053505-3.patch	4.46 KB

add-tem-not-when-reset-alphabetical-d7-2053505-3.patch	4.13 KB

Patches are attached

Comment #4

RoySegall CreditAttribution: RoySegall commented 30 July 2013 at 15:06

Status:

Active

» Needs review

Comment #5

30 July 2013 at 19:08

Status:

Needs review

» Needs work

The last submitted patch, add-tem-not-when-reset-alphabetical-d8-2053505-3.patch, failed testing.

Comment #6

RoySegall CreditAttribution: RoySegall commented 4 August 2013 at 10:12

Status:

Needs work

» Needs review

File	Size
add-tem-not-when-reset-alphabetical-d7-2053505-6.patch	5.33 KB

add-tem-not-when-reset-alphabetical-d8-2053505-6.patch	530.96 KB

I'm adjusting the tests to the new UX/UI.

Comment #7

4 August 2013 at 10:15

Status:

Needs review

» Needs work

The last submitted patch, add-tem-not-when-reset-alphabetical-d7-2053505-6.patch, failed testing.

Comment #8

RoySegall CreditAttribution: RoySegall commented 4 August 2013 at 12:31

Version:	8.x-dev	» 7.x-dev
Status:	Needs work	» Needs review

File	Size
add-tem-not-when-reset-alphabetical-d7-2053505-6.patch	5.33 KB

Pushing the 7.x patch for the simple test triggering.

Comment #9

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 5 August 2013 at 08:13

+++ b/modules/taxonomy/taxonomy.admin.incundefined
@@ -951,11 +942,9 @@ function taxonomy_vocabulary_confirm_delete_submit($form, &$form_state) {
+function taxonomy_overview_terms_reset($form, &$form_state, $vocabulary) {

@@ -973,7 +962,7 @@ function taxonomy_vocabulary_confirm_reset_alphabetical($form, &$form_state, $vi
-function taxonomy_vocabulary_confirm_reset_alphabetical_submit($form, &$form_state) {

Why change them name? taxonomy_overview_terms_reset_alphabetical sounds more correct.

+++ b/modules/taxonomy/taxonomy.testundefined
@@ -946,7 +945,7 @@ class TaxonomyTermTestCase extends TaxonomyWebTestCase {
+  function _testTaxonomyGetTermByName() {

Uncommenting a test isn't a good way to fix it ;)

Also if you want this patch to have any chance, it should be done first on D8, and then backported.