When the user reset the vocab terms to alphabetical order the "Add term" link still appear.

Steps to reproduce:
Create a vocab
Add two terms
Reset the vocab terms to alphabetical
You should see the Add term link
reset-alphabetical.png

Files: 
CommentFileSizeAuthor
#14 2053505-14-d8.png29.78 KBidebr
#11 add-tem-not-when-reset-alphabetical-d8-2053505-11.patch5.93 KBRoySegall
PASSED: [[SimpleTest]]: [MySQL] 58,270 pass(es).
[ View ]
#11 inner-diff.txt558 bytesRoySegall
#10 add-tem-not-when-reset-alphabetical-d8-2053505-10.patch5.39 KBRoySegall
PASSED: [[SimpleTest]]: [MySQL] 58,236 pass(es).
[ View ]
#8 add-tem-not-when-reset-alphabetical-d7-2053505-6.patch5.33 KBRoySegall
PASSED: [[SimpleTest]]: [MySQL] 40,020 pass(es).
[ View ]
#6 add-tem-not-when-reset-alphabetical-d8-2053505-6.patch530.96 KBRoySegall
PASSED: [[SimpleTest]]: [MySQL] 57,360 pass(es).
[ View ]
#6 add-tem-not-when-reset-alphabetical-d7-2053505-6.patch5.33 KBRoySegall
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch add-tem-not-when-reset-alphabetical-d7-2053505-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 add-tem-not-when-reset-alphabetical-d7-2053505-3.patch4.13 KBRoySegall
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch add-tem-not-when-reset-alphabetical-d7-2053505-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 add-tem-not-when-reset-alphabetical-d8-2053505-3.patch4.46 KBRoySegall
FAILED: [[SimpleTest]]: [MySQL] 57,924 pass(es), 8 fail(s), and 0 exception(s).
[ View ]
#1 d8-reset-term.png89.27 KBRoySegall
reset-alphabetical.png72.12 KBRoySegall

Comments

RoySegall’s picture

Version:7.x-dev» 8.x-dev
StatusFileSize
new89.27 KB

Also appear in Drupal 8 - change the version of the issue.

RoySegall’s picture

I'll supply a patch later on.

RoySegall’s picture

StatusFileSize
new4.46 KB
FAILED: [[SimpleTest]]: [MySQL] 57,924 pass(es), 8 fail(s), and 0 exception(s).
[ View ]
new4.13 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch add-tem-not-when-reset-alphabetical-d7-2053505-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patches are attached

RoySegall’s picture

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, add-tem-not-when-reset-alphabetical-d8-2053505-3.patch, failed testing.

RoySegall’s picture

Status:Needs work» Needs review
StatusFileSize
new5.33 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch add-tem-not-when-reset-alphabetical-d7-2053505-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new530.96 KB
PASSED: [[SimpleTest]]: [MySQL] 57,360 pass(es).
[ View ]

I'm adjusting the tests to the new UX/UI.

Status:Needs review» Needs work

The last submitted patch, add-tem-not-when-reset-alphabetical-d7-2053505-6.patch, failed testing.

RoySegall’s picture

Version:8.x-dev» 7.x-dev
Status:Needs work» Needs review
StatusFileSize
new5.33 KB
PASSED: [[SimpleTest]]: [MySQL] 40,020 pass(es).
[ View ]

Pushing the 7.x patch for the simple test triggering.

amitaibu’s picture

+++ b/modules/taxonomy/taxonomy.admin.incundefined
@@ -951,11 +942,9 @@ function taxonomy_vocabulary_confirm_delete_submit($form, &$form_state) {
+function taxonomy_overview_terms_reset($form, &$form_state, $vocabulary) {

@@ -973,7 +962,7 @@ function taxonomy_vocabulary_confirm_reset_alphabetical($form, &$form_state, $vi
-function taxonomy_vocabulary_confirm_reset_alphabetical_submit($form, &$form_state) {

Why change them name? taxonomy_overview_terms_reset_alphabetical sounds more correct.

+++ b/modules/taxonomy/taxonomy.testundefined
@@ -946,7 +945,7 @@ class TaxonomyTermTestCase extends TaxonomyWebTestCase {
+  function _testTaxonomyGetTermByName() {

Uncommenting a test isn't a good way to fix it ;)

Also if you want this patch to have any chance, it should be done first on D8, and then backported.

RoySegall’s picture

Version:7.x-dev» 8.x-dev
StatusFileSize
new5.39 KB
PASSED: [[SimpleTest]]: [MySQL] 58,236 pass(es).
[ View ]
RoySegall’s picture

StatusFileSize
new558 bytes
new5.93 KB
PASSED: [[SimpleTest]]: [MySQL] 58,270 pass(es).
[ View ]

Adding a minor fix the CSS of the button.

jhedstrom’s picture

Issue summary:View changes
Status:Needs review» Needs work
Issue tags:+Needs reroll

Patch in #11 no longer applies.

RoySegall’s picture

Don't think this is relevant any more.

idebr’s picture

Version:8.0.x-dev» 7.x-dev
Issue tags:-Needs reroll
StatusFileSize
new29.78 KB

I can confirm the 'Add term' no longer appears on the Reset confirmation form in 8.0.x, see screenshot:

The issue is still relevant for 7.x though