Problem/Motivation

#1981144: Convert block_admin_edit() in block.admin.inc to the new form interface converted the block configuration page callback to a controller for the normal menu item, but the default local task was not converted.

This route is not in the WSCCI meta task so probably overlooked.

I initially discovered this in a patch I'm writing where I use "admin/structure/blocks/manage/barik.login/configure" instead of just "admin/structure/blocks/manage/bartik.login".

Proposed resolution

Convert the default local task to use the block_admin_edit route.

Remaining tasks

  • Need patch
  • Need review
  • Need test

User interface changes

None.

API changes

See WSCCI

Files: 
CommentFileSizeAuthor
#4 drupal-2052019-block-configure-local-task-test-only-4.patch1.42 KBgvso
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,527 pass(es).
[ View ]
#2 drupal-2052019-block-configure-local-task-test-only.patch1.47 KBmradcliffe
FAILED: [[SimpleTest]]: [MySQL] 57,763 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 page-not-found.png39.56 KBmradcliffe

Comments

mradcliffe’s picture

StatusFileSize
new39.56 KB

Added screenshot.

mradcliffe’s picture

Status:Active» Needs review
StatusFileSize
new1.47 KB
FAILED: [[SimpleTest]]: [MySQL] 57,763 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Here is a test that demonstrates the bug.

The last submitted patch, drupal-2052019-block-configure-local-task-test-only.patch, failed testing.

Anonymous’s picture

Issue summary:View changes

Corrected my paths,

gvso’s picture

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new1.42 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,527 pass(es).
[ View ]

Hi I re-rolled your patch and make the test work. It seems that everything works fine.

gvso’s picture

Status:Needs review» Closed (cannot reproduce)

The patch in #1981144 configure the route of block_admin_edit as /admin/structure/block/manage/{block}. This issue is not reproducible