Improve error reporting when PHP lacks POSIX support [#2049983]

If you are running PHP on certain RHEL distributions like CentOS POSIX support is off by default.

When posix support is missing running:
drush site-set @dev yields no output
drush site-set @dev -v yields "Command dispatch complete"
It is important to note that in these circumstances a persistent alias is not set.

For CentOS a user could fix this by running yum install php-process followed by an apache restart.
Currently the only way to know POSIX is the cause is to read through the drush include files. It would be better under these circumstances to throw an error to help newer users debug the issue.

Patch to follow.

Comment	File	Size	Author
#3	drush-error_on_posix_missing-2049983-3.patch	1.15 KB	Darren Shelley
#1	drush-error_on_posix_missing-2049983-1.patch	1.19 KB	Darren Shelley

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Darren Shelley CreditAttribution: Darren Shelley commented 25 July 2013 at 08:29

Status:

Active

» Needs review

File	Size
drush-error_on_posix_missing-2049983-1.patch	1.19 KB

Patch attached to add error reporting, please review.

Thankyou

Comment #1.0

Darren Shelley CreditAttribution: Darren Shelley commented 25 July 2013 at 08:33

Issue summary:

View changes

improve english

Comment #2

moshe weitzman CreditAttribution: moshe weitzman commented 25 July 2013 at 18:33

Status:

Needs review

» Needs work

Technically, that should go in a validate hook in the same file. See docs/drush.api.php

Comment #3

Darren Shelley CreditAttribution: Darren Shelley commented 26 July 2013 at 10:11

File	Size
drush-error_on_posix_missing-2049983-3.patch	1.15 KB

Thank you for the advice, I have reviewed the API documentation and revised the patch.

The patch now provides a validation callback for site-set.

The error message has been written more generically and in line with existing standards to provide easier scope for translation in the future.

Comment #4

Darren Shelley CreditAttribution: Darren Shelley commented 26 July 2013 at 10:21

Status:

Needs work

» Needs review

Comment #5

greg.1.anderson CreditAttribution: greg.1.anderson commented 26 July 2013 at 18:16

This looks fine to me. I wonder if we should consider a general feature in command.inc to support "php function dependencies" to go with "drush dependencies" and "drupal dependencies"? Could be a follow-on issue.