Remove 'Theming information' feature from Views in favor of twig_debug

This is a bit different than I thought, and maybe it would be nice to make this code theme engine agnostic.

Add STR

Retitling.

Add screenshot

Thanks @Manuel Garcia :) that gets them all.

Looking at this again it looks possible to be theme engine agnostic, there is some existing code in this class to do this which would be nice to try and reuse. It's in a big switch statement but maybe this code could be moved out into a helper method?

      case 'analyze-theme':
        $form['#title'] .= t('Theming information');
        if ($theme = drupal_container()->get('request')->request->get('theme')) {
          $this->theme = $theme;
        }
        elseif (empty($this->theme)) {
          $this->theme = config('system.theme')->get('default');
        }

        if (isset($GLOBALS['theme']) && $GLOBALS['theme'] == $this->theme) {
          $this->theme_registry = theme_get_registry();
          $theme_engine = $GLOBALS['theme_engine'];
        }
        else {
          $themes = list_themes();
          $theme = $themes[$this->theme];

          // Find all our ancestor themes and put them in an array.
          $base_theme = array();
          $ancestor = $this->theme;
          while ($ancestor && isset($themes[$ancestor]->base_theme)) {
            $ancestor = $themes[$ancestor]->base_theme;
            $base_theme[] = $themes[$ancestor];
          }

          // The base themes should be initialized in the right order.
          $base_theme = array_reverse($base_theme);

          // This code is copied directly from _drupal_theme_initialize()
          $theme_engine = NULL;

          // Initialize the theme.
          if (isset($theme->engine)) {
            // Include the engine.
            include_once DRUPAL_ROOT . '/' . $theme->owner;

            $theme_engine = $theme->engine;
            if (function_exists($theme_engine . '_init')) {
              foreach ($base_theme as $base) {
                call_user_func($theme_engine . '_init', $base);
              }
              call_user_func($theme_engine . '_init', $theme);
            }
          }
          else {
            // include non-engine theme files
            foreach ($base_theme as $base) {
              // Include the theme file or the engine.
              if (!empty($base->owner)) {
                include_once DRUPAL_ROOT . '/' . $base->owner;
              }
            }
            // and our theme gets one too.
            if (!empty($theme->owner)) {
              include_once DRUPAL_ROOT . '/' . $theme->owner;
            }
          }
          $this->theme_registry = _theme_load_registry($theme, $base_theme, $theme_engine);
        }

        // If there's a theme engine involved, we also need to know its extension
        // so we can give the proper filename.
        $this->theme_extension = '.html.twig';
        if (isset($theme_engine)) {
          $extension_function = $theme_engine . '_extension';
          if (function_exists($extension_function)) {
            $this->theme_extension = $extension_function();
          }
        }

Something like this. Interdiff is the same size as the patch, so not uploading it.

Thank you @lokapujya and @Manuel Garcia! The latest patch shrunk a bit, I think we still want to move the code from within the 'analyze-theme' case to the getThemeInformation method.

This is still failing tests locally for me but I don't think we want the repeated code. I just cut the code and pasted it back into getThemeInformation to include some recent changes. Probably something small would explain why this doesn't work but I haven't had a chance to debug. Manual testing might help.

Something like this perhaps…

Edit: although, this seems like now the code in the helper function could be run up to 4 times within the analyze-theme case.

Okay, well #9 is the patch to review then! :)

I've never used this functionality myself. Another question might be do we need this with twig_debug in core?

Yes, when twig_debug is enabled we display all possible template suggestions and show the current one in use (marked with an x).

https://drupal.org/node/1922666

Retitling, tweaking the issue summary, and adding a couple related issues.

#2118743: Twig debug output does not display all suggestions when an array of theme hooks is passed to #theme was opened to make sure an array of theme hooks passed to _theme() is displayed in twig_debug output, but that looks like it will be solved by #2201781: Pass all theme hook suggestions to theme preprocess functions to allow for suggestion-specific overrides though.

I'll post a rough initial patch at #2201781: Pass all theme hook suggestions to theme preprocess functions to allow for suggestion-specific overrides in a few minutes but here's a before/after example:

Before patch

<!-- THEME DEBUG -->
<!-- CALL: _theme('views_view') -->
<!-- BEGIN OUTPUT from 'core/modules/views/templates/views-view.html.twig' -->

After patch

<!-- THEME DEBUG -->
<!-- CALL: _theme('views_view') -->
<!-- FILE NAME SUGGESTIONS:
   * views-view--content--page-1.html.twig
   * views-view--page-1.html.twig
   * views-view--default.html.twig
   * views-view--content--page.html.twig
   * views-view--page.html.twig
   * views-view--content.html.twig
   x views-view.html.twig
   x views-view.html.twig
-->
<!-- BEGIN OUTPUT from 'core/modules/views/templates/views-view.html.twig' -->

Obviously we don't want views-view.html.twig there twice, but you get the idea :)