Cleanup user interface text on appearance/settings

+1 for this cleanup. Patch needs a reroll though.

I'd say RTBC. Not sure if this needs more review since it is a UI change (is it even possible for 8.0.0 at this point)?

Not 100% happy with this! I think we need to be more brutal with this cleanup.

This whole page is sort of spaghetti. We're at Drupal South and I've decided I want to fix it. Here's why:

• Field label names are weird, as described in this issue. But they're not weird because they're just "not right", they're weird because the whole UX of this page is weird. We're trying to put lipstick on a pig here and I think we should change the UX properly. This page has needed some love for years.
• Under "Toggle Display" we have a mish-mash of different things that seem to be in the wrong order and not all configurable from this screen. eg. Logo, site name, site slogan and favicon seem like they should be grouped and then user pictures in posts, user pictures in comments, user verification status in comments seem like they should be grouped (and also probably do not belong on this page because I may not have users, posts or comments so considering how top-level this page is I think it's a bit out of date.)
• I can un-check logo and I am able to configure my custom logo. But if I uncheck site name, I can't configure a site name. I have to go to the Site Information section to configure my site name and slogan. Surely the pattern for turning on logo display configuring my logo and turning on the site name display and configuring my site name should be the same. Especially because there is literally nowhere on this page that tells me that I should go to Site Information to configure site name and slogan.
• User settings should be in at least a different fieldset from logo/name/slogan/favicon settings but possibly even on a different form. Is this "appearance" section trying to do too much? Is this really an aggregation of all things we can turn on and off in the Drupal UI? I highly doubt that. It seems like this form is trying to do too much for too many different little use cases but has ended up just being a bit confusing.
• Why are all these fieldsets collapsible? What purpose does it possible serve to collapse any of these fields? They are all un-collapsed by default anyway. Surely it would be easier for people to understand what is happening on this page if they could see that they could add their logo right at the start rather than having to check a box to see that functionality is available to them.

As for the nitty-gritty:

• Need to make it clear that linking to an icon and uploading an icon won't both work. Should be radio buttons, they shouldn't be both available.
• No point in calling it both a "shortcut icon", a "favicon" and a "favicon image". Choose one, I choose "shortcut icon" because that's apparently the standard and not biased towards Microsoft.
• I actually think the text at the top of the screen was better before this edit. The edit has assumed knowledge about "theme-specific settings" which is a bit developer-y and might confuse someone new.
• Choose "logo" or "logo image" but not both. I'm choosing just "logo".
• Not convinced that "Page element display" is a good phrase. How about "Site branding"? Then underneath, the labels for the checkboxes can be
  • Show a logo - which pops down options to upload your logo, etc.
  • Show a site name - same as above.
  • The description can be modified to actually describe where these things are being "shown" - for Branding, these things are being shown on every page.

So I've uploaded a bunch of hand-drawn wireframe prototypes and am currently working on a patch. Very keen for UX team input and excited about making this all better.

If we're keen to move forward with this I'm happy to either update the issue summary or make this a new issue.

I am trying to review this - but struggling a bit. Are there before/after screenshots?

I love all the consistency and thought in this patch :)

I'm finding many inconsistencies throughout all pages. Is there a better way to provide that feedback than a separate issue for each one? Maybe a master user interface text file that could be redlined?

At least a rerool of #4, and screenshots.
Missing meeli's remarks.

Before :

After :

Thanks pguillard,

the patch does clean up the existing text nicely by getting rid of unnecessary words. I also like the favicon change that still keeps the "shortcut icon" in the help text.

There are much more points raised in #6 but that means a much bigger overhaul of these pages, and beyond the scope of this issue.
So let's just get this in first so that users have a cleaner UI for now, and then proceed to the bigger task as a different issue.

I'm not going to complain, thank you :p

Thanks everyone; all the string changes in this patch look great.

1. +++ b/core/modules/system/src/Form/ThemeSettingsForm.php
   @@ -152,9 +152,8 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
   -      '#title' => t('Toggle display'),
   +      '#title' => t('Page element display'),
          '#open' => TRUE,
   -      '#description' => t('Enable or disable the display of certain page elements.'),
   

   This is a great cleanup!

2. +++ b/core/modules/system/src/Form/ThemeSettingsForm.php
   @@ -210,10 +209,9 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
   -        '#title' => t('Shortcut icon settings'),
   +        '#title' => t('Favicon'),
   
   @@ -223,7 +221,7 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
   -        '#title' => t('Use the default shortcut icon supplied by the theme'),
   +        '#title' => t('Use the favicon supplied by the theme'),
   
   @@ -242,7 +240,7 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
   -        '#title' => t('Upload icon image'),
   +        '#title' => t('Upload favicon image'),
   

   +1 for making these consistent; that makes the page easier to understand.

3. +++ b/core/modules/system/src/Form/ThemeSettingsForm.php
   @@ -210,10 +209,9 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
   -        '#description' => t("Your shortcut icon, or 'favicon', is displayed in the address bar and bookmarks of most browsers."),
   -        '#states' => array(
   +        '#description' => t("Your shortcut icon, or favicon, is displayed in the address bar and bookmarks of most browsers."),        '#states' => array(
   

   Looks like a newline was accidentally deleted here.

NW for fixing that last point.

Oops, new patch removing the newline

Reviewed and tested after applying patch. It looks fine.

Thank you @Anul for your review.
Meanwhile, I guess the bot went crazy , I started a new test.

You are Welcome @pguillard
Have you created a new issue for the same or shall i review it again n move it accordingly.

@Anul, no need to create a new issue, for some reason, the bot didn't launched an error.
Now, yes, you can set it to RTBC if you think it is fine! As I can't on my side.

Reviewed and tested after applying patch #20 . It looks fine. Screen shot added in #21..

As this patch #20 is failing automation testing. I am adding a new patch for the same.

I test this patch.It looks fine.

This looks great now. Committed 43f4378 and pushed to 8.2.x. Thanks!