Fixed position toolbar blocks the "X" close button in the modal.

See image for explanation.

CommentFileSizeAuthor
#6 references_dialog-close_button-2048777-6.patch2.45 KBacrollet
#4 references_dialog-close_button-2048777-4.patch404 bytesl0ke
#2 references_dialog-close_button-2048777-2.patch1.18 KBbgilhome
Screenshot 7:23:13 3:53 PM.png93.17 KBAaronBauman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hefox’s picture

hefox CreditAttribution: hefox commented

Can confirm with rubik

bgilhome’s picture

bgilhome CreditAttribution: bgilhome commented
Issue summary: View changes
FileSize
references_dialog-close_button-2048777-2.patch1.18 KB

This seems to occur because the iframe gets some css updated when the parent window is scrolled, and the top gets set too high (10px). I've created a patch to disable scrolling parent window when dialog is open - hopefully this is suitable.

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented
Status: Active » Needs work

I'm going through the issue queue now in preparation for tagging a new release. It would be great to get some eyes on bgilhome's proposed fix/patch.

l0ke’s picture

l0ke
Primary language English
Location Ukraine
CreditAttribution: l0ke commented
FileSize
references_dialog-close_button-2048777-4.patch404 bytes

This issue caused by jQuery UI 1.10 that comes with last jQuery Update module. The thing is that in jQuery UI 1.10 the zIndex option is removed. So dialog now has default z-index: 100; that is less than Toolbar has.
We now have to set z-index directly in the css.

l0ke’s picture

l0ke
Primary language English
Location Ukraine
CreditAttribution: l0ke commented
Status: Needs work » Needs review
acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented
FileSize
references_dialog-close_button-2048777-6.patch2.45 KB

I think it's worth combining the two approaches - attached patch combines the previous two, and also sets the modal height to 85% of the window height instead of 90. (I was having the bottom go slightly off-screen)

aDarkling’s picture

aDarkling CreditAttribution: aDarkling as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Tried #6 with jQuery UI 1.10 on Chrome and Chrome Mobile.
I too was having a problem with a disappearing bottom. This fixed that as well.
I also like that it stops the background content from scrolling.
The code looks good.

+1 RTBC

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented

This looks good and tests ok. But I'm leaning toward lowering the height even more to 75%. There's no reason a dialog box should take up the entire screen.

  • WorldFallz committed 0974daa on 7.x-1.x authored by acrollet 
    Issue #2048777 by l0ke, bgilhome, acrollet: Can't get to close button in...
WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented
Status: Reviewed & tested by the community » Fixed

Committed #6 but with height at 75%.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.