Given that the simple cache saves how long the object should be cached for, shouldn't the cache 'expire' value be set accordingly?

Files: 
CommentFileSizeAuthor
#7 panels-n2048011-7.patch667 bytesMichelle
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#3 panels-n2048011-3.patch644 bytesDamienMcKenna
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch panels-n2048011-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

DamienMcKenna’s picture

Project:Panels» Chaos tool suite (ctools)
Version:7.x-3.x-dev» 7.x-1.x-dev

Moving this to the CTools issue queue.

DamienMcKenna’s picture

Project:Chaos tool suite (ctools)» Panels
Version:7.x-1.x-dev» 7.x-3.x-dev

Wait, no, this is for Panels' version of the simple cache plugin.

DamienMcKenna’s picture

Status:Active» Needs review
StatusFileSize
new644 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch panels-n2048011-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

This sets the expiration to time() + $conf['lifetime'] if the value is set, otherwise it leaves it set to CACHE_PERMANENT.

DamienMcKenna’s picture

Issue summary:View changes
Status:Needs review» Needs work
DamienMcKenna’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 3: panels-n2048011-3.patch, failed testing.

Michelle’s picture

Status:Needs work» Needs review
StatusFileSize
new667 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

I re-rolled this patch and it applies cleanly, now, but I haven't tested to see if it works.

SocialNicheGuru’s picture

Does this integrate with the cache_expire module?

DamienMcKenna’s picture

Nope, it's completely separate.

robmcbryde queued 7: panels-n2048011-7.patch for re-testing.