Add notes here.
Reorganizing under "stat methods" component.
Here's a start. Still todo, tests for:
Note PHPUnit for contrib is almost broken. This'll need #2025883: Drupal's PHPUnit bootstrap.php does not register module namespaces out of /core in order to run.
By which, I of course mean...
Adding coverage for StatPluginmethodBase::collect() and cleaning up a number of other tests.
Still needs coverage on StatPluginMethodBase::manageData().
Setting "needs review" to illustrate the core bug referenced in #2.
The last submitted patch, sapi-unit_tests-statpluginmethodbase-2047321-4.patch, failed testing.
Full coverage of the base class; had to do some silly wrapping of watchdog because it's not an injectable service.
The last submitted patch, sapi-unit_tests_statpluginmethodbase-2047321-7.patch, failed testing.
#7: sapi-unit_tests_statpluginmethodbase-2047321-7.patch queued for re-testing.
Getting rid of the wrapper class and using the getMockForAbstractClass method. Also making those config getter/setter methods to public.
The last submitted patch, sapi-unit_tests_statpluginmethodbase-2047321-11.patch, failed testing.
Adding a "label" key.
The last submitted patch, sapi-unit_tests_statmethod_storage_controller-2053423-13.patch, failed testing.
Anywhere the watchdog() function is already defined, the associated constants will also already be defined... So here's this.
Finally committed e8a5882 + @todos for removal once watchdog is injectable or something similar.
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
iamEAP CreditAttribution: iamEAP commentedReorganizing under "stat methods" component.
Comment #2
iamEAP CreditAttribution: iamEAP commentedHere's a start. Still todo, tests for:
Note PHPUnit for contrib is almost broken. This'll need #2025883: Drupal's PHPUnit bootstrap.php does not register module namespaces out of /core in order to run.
Comment #3
iamEAP CreditAttribution: iamEAP commentedBy which, I of course mean...
Comment #4
iamEAP CreditAttribution: iamEAP commentedAdding coverage for StatPluginmethodBase::collect() and cleaning up a number of other tests.
Still needs coverage on StatPluginMethodBase::manageData().
Comment #5
iamEAP CreditAttribution: iamEAP commentedSetting "needs review" to illustrate the core bug referenced in #2.
Comment #7
iamEAP CreditAttribution: iamEAP commentedFull coverage of the base class; had to do some silly wrapping of watchdog because it's not an injectable service.
Comment #9
iamEAP CreditAttribution: iamEAP commented#7: sapi-unit_tests_statpluginmethodbase-2047321-7.patch queued for re-testing.
Comment #11
iamEAP CreditAttribution: iamEAP commentedGetting rid of the wrapper class and using the getMockForAbstractClass method. Also making those config getter/setter methods to public.
Comment #13
iamEAP CreditAttribution: iamEAP commentedAdding a "label" key.
Comment #15
iamEAP CreditAttribution: iamEAP commentedAnywhere the watchdog() function is already defined, the associated constants will also already be defined... So here's this.
Comment #16
iamEAP CreditAttribution: iamEAP commentedFinally committed e8a5882 + @todos for removal once watchdog is injectable or something similar.