Left-over from #2002102: Move TypedData primitive types to interfaces - that key does not exist any more.

CommentFileSizeAuthor
#20 2047119-after_patch-14.png117.81 KBAbhijith S
#18 Screen Shot 2020-07-29 at 6.37.36 PM.png328.98 KBtanubansal
#18 Screen Shot 2020-07-29 at 6.34.11 PM.png327.64 KBtanubansal
#14 d8_typed_docs.patch1.71 KBfago
#12 remove-deprecated-2047119-12.patch1.73 KBmsankhala
#1 2047119-1.patch1.57 KBLinL
d8_primitive_leftover.patch750 bytesfago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LinL’s picture

LinL CreditAttribution: LinL commented
Issue summary: View changes
Issue tags: +Documentation
FileSize
2047119-1.patch1.57 KB

Rerolled as the patch no longer applied.

I've also changed where \Drupal\Core\TypedData\Primitive was mentioned, as it no longer exists. I've changed it to \Drupal\Core\TypedData\PrimitiveBase but I don't know if that is correct? Or maybe it should be \Drupal\Core\TypedData\PrimitiveInterface ? Or neither?!

Berdir queued 1: 2047119-1.patch for re-testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented 
+++ b/core/lib/Drupal/Core/TypedData/Annotation/DataType.php
@@ -16,10 +16,10 @@
  * Defined data types may map to one of the pre-defined primitive types in

I might be missing something here, but how is PrimitiveBase defining types?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Status: Needs review » Needs work

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Version: 8.5.x-dev » 8.6.x-dev
msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented 
+++ b/core/lib/Drupal/Core/TypedData/Annotation/DataType.php
@@ -16,10 +16,10 @@
- * \Drupal\Core\TypedData\Primitive or may be complex data types, containing on
- * or more data properties. Typed data objects for complex data types have to
- * implement the \Drupal\Core\TypedData\ComplexDataInterface. Further interface
- * that may be implemented are:
+ * \Drupal\Core\TypedData\PrimitiveBase or may be complex data types, containing

I think correct way to define this should be.

Defined data types may map to one of the pre-defined primitive types that implements \Drupal\Core\TypedData\PrimitiveInterface

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
remove-deprecated-2047119-12.patch1.73 KB

Here is updated patch.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
FileSize
d8_typed_docs.patch1.71 KB

Well, primitive base is just the base class, but does not really point you to the interfaces. They are below \Type - updated the patch accordingly.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tanubansal’s picture

tanubansal CreditAttribution: tanubansal at Salsa Digital commented
FileSize
Screen Shot 2020-07-29 at 6.34.11 PM.png327.64 KB
Screen Shot 2020-07-29 at 6.37.36 PM.png328.98 KB

Tested via #14.
This can be moved to RTBC

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
FileSize
2047119-after_patch-14.png117.81 KB

Applied patch #14 on 9.2.x and it works fine.

after

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

Came across this in passing, and happy to find there was an existing issue.

  • catch committed 5d7ae05 on 9.3.x 
    Issue #2047119 by fago, msankhala, LinL: Remove deprecated documentation...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 5d7ae05 and pushed to 9.3.x. Thanks!

  • catch committed 593b09f on 9.2.x 
    Issue #2047119 by fago, msankhala, LinL: Remove deprecated documentation...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.