The admin/modules page has table headers whose text overlaps. The left-most column has the word "ENABLED" as its column header, but that is supposed to be invisible text. Instead it is overlapping the next column header, making both illegible. Screenshot attached from Chrome 28. Also verified in Safari 6.

The problem is caused by use of the CSS class "element-invisible" which is no longer part of D8. That class has been replaced with "visually-hidden". This is a follow-up fix to #1990544: Convert system_modules() to a Controller which used the CSS class "element-invisible".

This will be an easy one-line fix.



bowersox’s picture

Status:Active» Needs review
new153.77 KB
new1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 57,226 pass(es).
[ View ]

1-line patch attached. It fixed the CSS class so the header goes back to being invisible, and no text overlaps. A screenshot is also attached (showing the correct, patched display).

Please review.

tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

Closed #2046327: CSS regression in table header on admin/modules ("Enabled" header not hidden) as a dupe. Let's get this in before more issues get filed.

xjm’s picture

Title:Admin Modules CSS style causing overlapping table headers» CSS regression on admin/modules: overlapping "Enabled" table header not properly invisible
xjm’s picture

new6.04 KB

It works:


hass’s picture

Status:Reviewed & tested by the community» Needs work
bowersox’s picture

We might want to get this patch in place in order to fix this visual overlap bag. If the CSS class name change happens in that other issue, there would be a global search-and-replace that would change the name used here to whatever the new name will be. But in the mean time I don't think we want to leave the D8 codebase in this inconsistent state with a bug that everyone who uses the Modules page will see. My vote is for RTBC on this simple fix.

xjm’s picture

Status:Needs work» Reviewed & tested by the community

@hass, no, it is not NW until that issue has consensus. This is a bugfix.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 96868e9 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.