The "all of" and "none of" operators miss the condition for checking the entity_type

Subscribing. Similar issue here using CCK and views filters. User and Node both reference a taxonomy term Source. A view displaying all nodes filtered on type 'article' and 'source' retrieve nodes with the ID of User.

Example Database, field_data_field_source:

(entity_type, bundle, entity_id, field_source_id)
(node, article, 1, 1)
(user, user, 1, 2)

The SQL generated does not filter on entity_type or bundle and will retrieve the Source with tid 2.

Any quick workaround ?

Also got the issue too.

I use same field on node and commerce_product to reference.
In filter got two options, but only affect field options, entitty_type not in the condition.

I get this issue trying to filter file entities by multiple taxonomy terms to make a filtered photo gallery. This is a fairly common use case for D7 and media module.

I would also love to find a workaround.

The previous comments explain this well, but here are some details and an exported view that show the bug.

Modules:
Drupal 7.23
Ctools 7.x-1.3+4-dev
Views 7.x-3.7+12-dev
File Entity 7.x-2.0-alpha3

Images (file entities with a tags field added):
"Apple"[1] tagged: apple[1]
"Banana"[2] tagged: banana[2]

Articles (node entities):
"Fruit"[1] tagged: apple[1],banana[2]
"Red Delicious"[2] tagged: apple[1],red[3]

from field_revision_field_tags:
entity_type | bundle | entity_id | field_tags_tid
file | image | 1 | 1
file | image | 2 | 2
node | article | 1 | 1
node | article | 1 | 2
node | article | 2 | 1
node | article | 2 | 3

With the attached file view, here are the unexpected results:
Operator | Tags | Result image name
"is all of" | apple,red = "Banana"
"is all of" | apple = "Apple", "Apple", "Banana"
"is all of" | apple,banana = "Apple", "Apple", "Banana"
"is all of" | banana = "Apple", "Banana"

This also seems to be the case for the "is none of" operator:
"is none of" | apple = no result

Here's a workaround that works for my view which is a file entity view with a bunch of exposed taxonomy filters. The filters are set to allow multiple values and use the "is all of" operator.

function my_module_views_query_alter(&$view, &$query) {
    if($view->name == 'my_view') {
      $terms = $query->table_queue;
      foreach($terms as $key=>$term) {
      	//find the ones that are multiples by checking for the incremented integer at the end
        if(strpos($key, 'field_data_field') === 0 && is_numeric(substr($key, -1))) {
          $terms[$key]['join']->extra[0]['field'] = 'entity_type';
          $terms[$key]['join']->extra[0]['value'] = 'file';
        }
      }
    }
}

This appears to be the case for taxo filters in general. I have a "field_brand" that holds taxo references in both node and commerce_product node types. Using an exposed filter on "field_brand" returns incoherent results because it returns all the entity_id values from field_data_field_brand regardless of entity_type.

Here's why that's a problem:

mysql> select entity_type, entity_id from field_data_field_brand where field_brand_tid = 3615;
+------------------+-----------+
| entity_type      | entity_id |
+------------------+-----------+
| commerce_product |      5335 |
| commerce_product |      6940 |
| commerce_product |      7085 |
| commerce_product |      7086 |
| commerce_product |      7087 |
| commerce_product |      7559 |
| commerce_product |      7562 |
| node             |      3426 |
| node             |      3428 |
| node             |      5308 |
| node             |      5496 |
| node             |      5497 |
| node             |      5498 |
| node             |      5499 |
| node             |      6017 |
| node             |      6384 |
| node             |      6388 |
| node             |      6603 |
| node             |      6604 |
| node             |      6615 |
| node             |      6616 |
| node             |      6617 |
| node             |      6618 |
+------------------+-----------+

Updated the version to reflect the fact that this is still the case in 3.11.

This still appears to be an issue. Even though it's probably a rare occurrence, it's a pretty major problem when it hits. As far as I can tell, the problem happens when 2 entities of different types both use the same field, and have the same ID, but different values for the field in question.

For example, say nodes and files both use an "Archived" (on/off) field. If a particular node, which is NOT archived, and a particular file, which IS archived, both have the same ID (ie, the FID is the same as the NID), then any Views filters using the "all of" or "none of" operators will treat the node as if it WERE archived.

I'm attaching a patch which seems to fix it for me. I would recommend careful review though, as I'm unfamiliar with Views, and obviously this is a change that would have immediate impact on tons of sites. In particular I worry about D7 sites that may already be using hook_views_query_alter() to deal with this problem.

I'd also note that it's not a 100% complete solution, as mentioned in the @TODO. Hopefully it is helpful in pinpointing the problem though.

The 2 year old patch in #8 to handlers.inc applied cleanly to the latest views 7.x-3.x-dev, but still needs review.