Add drupal_alter() to entityCacheGet & entityCacheSet & resetEntityCache

correcting status

Arrays of objects don't usually need to be passed by reference, because the objects inside the arrays are references by default as of PHP 5. Can someone explain why this is needed?

Would actual alter hooks on both entityCacheGet and entityCacheSet() help here? Implementing hook_entitycache_node_load_alter() would be a more proper place to *unset* an entity from the array, rather than using hook_entitycache_node_load().

This is by design. You shouldn't be able to mess with the actual list of entities here. And it's the same for hook_node_load().

I disagree and think this is still worth considering.

And it's the same for hook_node_load().

I don't understand what this is supposed to mean.

I updated a minor typo.

No-one's explained why you need to be able to remove items from the array of entities.

Can't SPS implement hook_entity_load_uncached() and do the replacement in there?

Re rolling the patch against 7.x-1.5.

Re rolling the patch against 7.x-1.5. Updated the file path.

This needs documentation in entitycache.api.php. This is also a feature request, not a bug.

1. +++ b/includes/entitycache.entitycachecontrollerhelper.inc
   @@ -227,12 +227,21 @@ class EntityCacheControllerHelper extends DrupalDefaultEntityController {
   +        drupal_alter(array('entitycache_load', 'entitycache_' . $controller->entityType . '_load'), $cached_entities);
   

   Just before this in the self::entityCacheAttachLoad($controller, $cached_entities); call we already have a chance to alter entities one by one with hook_entitycache_load(). So not sure when this is necessary but if it is, let's throw hook_entitycache_load() out.

2. +++ b/includes/entitycache.entitycachecontrollerhelper.inc
   @@ -227,12 +227,21 @@ class EntityCacheControllerHelper extends DrupalDefaultEntityController {
   +    drupal_alter(array('entitycache_save', 'entitycache_' . $controller->entityType . '_save'), $entities);
   

   I would call this hook_entitycache_set_alter() since we usually say 'setting' the cache instead of 'saving' it.

The attached patch addresses the above issues and also creates a hook_entitycache_postset_alter() to alter the entities after saving them to the cache. My use case is #2768857: Overwritten titles when using entitycache, panelizer and entity_translation modules.

An entity type argument was missing from drupal_alter().

Thanks for all the work on this, I needed this too but already worked on it before seeing this issue.

So I am sorry for posting yet another patch, but I am sure we can combine (and also get a quick commit).

--

I am not seeing why we need postset right now, but I added some more to deal with clearing caches, which is very useful.

Also the alter should be before retrieving from cache (I am implementing this for CPS, a module like SPS).

If I can see why postset is needed, I'll add it later.

Okay, I get the use case, I added it to my patch, so we can get quick RTBC and commit.

Committed/pushed to 7.x-1.x, thanks!

Had a couple of ropey releases with entitycache, so will leave this in dev for a little while.