I want to integrate TMGMT with configuration translation.

As with other language overview pages, I want to mess with it and allow to create a translation job and let someone else do the hard work ;)

You can see in the screenshots in our documentation how that currently looks for content translation: https://drupal.org/node/1490130

Patch will follow in a second...

Files: 
CommentFileSizeAuthor
#10 alter-hook-2041067-8.patch2.71 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 467 pass(es). View
#1 alter-hook-2041067-1.patch2.67 KBBerdir
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch alter-hook-2041067-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
2.67 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch alter-hook-2041067-1.patch. Unable to apply patch. See the log in the details link for more information. View

This would be a one line patch if it weren't for injection and documentation ;)

Completely untested :)

Gábor Hojtsy’s picture

Issue tags: +Needs tests

What about a test that includes the code from the hook doc and checksif it works? Looks like you have the starting point for that test as part of the docs.

Gábor Hojtsy’s picture

Are you interested to provide tests for this?

Berdir’s picture

I'm currently looking into a generic way to alter a controller response. If that doesn't work out then I'll get back to this and provide tests.

YesCT’s picture

@Berdir any more info for this?

Gábor Hojtsy’s picture

@Berdir: would be good to resolve this, since we are proposing this module to core and don't want any issues remaining like this that we know and could have resolved.

Gábor Hojtsy’s picture

#1: alter-hook-2041067-1.patch queued for re-testing.

Gábor Hojtsy’s picture

@Berdir: any news on this one?

Status: Needs review » Needs work

The last submitted patch, alter-hook-2041067-1.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
2.71 KB
PASSED: [[SimpleTest]]: [MySQL] 467 pass(es). View

Rerolled. Lacking tests still...

YesCT’s picture

@Berdir we are trying to close all the issues in the queue to get ready to get it into core. Do you think it is ok to wait till we are in core for this?

Berdir’s picture

Yes.

I'll either get the patch into core or use the bruteforce method of altering the route.

Gábor Hojtsy’s picture

Priority: Normal » Minor

Demoted then.

Gábor Hojtsy’s picture

Title: Allow other modules to alter the language overview page » Add easier way to alter the language overview page in config translation
Project: (Obsolete) configuration translation for Drupal 8 » Drupal core
Version: 8.x-1.x-dev » 8.x-dev
Component: Code » config_translation.module
Issue summary: View changes
Issue tags: +D8MI, +language-config

Moving to core queue. @Berdir: what do you think now? :)

Gábor Hojtsy’s picture

Status: Needs review » Needs work

Also need reroll for core.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.