I want to integrate TMGMT with configuration translation.
As with other language overview pages, I want to mess with it and allow to create a translation job and let someone else do the hard work ;)
You can see in the screenshots in our documentation how that currently looks for content translation: https://drupal.org/node/1490130
Patch will follow in a second...
Comment | File | Size | Author |
---|---|---|---|
#10 | alter-hook-2041067-8.patch | 2.71 KB | Gábor Hojtsy |
#1 | alter-hook-2041067-1.patch | 2.67 KB | Berdir |
Comments
Comment #1
BerdirThis would be a one line patch if it weren't for injection and documentation ;)
Completely untested :)
Comment #2
Gábor HojtsyWhat about a test that includes the code from the hook doc and checksif it works? Looks like you have the starting point for that test as part of the docs.
Comment #3
Gábor HojtsyAre you interested to provide tests for this?
Comment #4
BerdirI'm currently looking into a generic way to alter a controller response. If that doesn't work out then I'll get back to this and provide tests.
Comment #5
YesCT CreditAttribution: YesCT commented@Berdir any more info for this?
Comment #6
Gábor Hojtsy@Berdir: would be good to resolve this, since we are proposing this module to core and don't want any issues remaining like this that we know and could have resolved.
Comment #7
Gábor Hojtsy#1: alter-hook-2041067-1.patch queued for re-testing.
Comment #8
Gábor Hojtsy@Berdir: any news on this one?
Comment #10
Gábor HojtsyRerolled. Lacking tests still...
Comment #11
YesCT CreditAttribution: YesCT commented@Berdir we are trying to close all the issues in the queue to get ready to get it into core. Do you think it is ok to wait till we are in core for this?
Comment #12
BerdirYes.
I'll either get the patch into core or use the bruteforce method of altering the route.
Comment #13
Gábor HojtsyDemoted then.
Comment #14
Gábor HojtsyMoving to core queue. @Berdir: what do you think now? :)
Comment #15
Gábor HojtsyAlso need reroll for core.