Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1921152: META: Start providing tour tips for other core modules.
Problem/Motivation
Write tour integration for Extend admin page
Proposed resolution
Create tour yml files for required admin screens in admin/modules.
Remaining tasks
Create patch for tour integration for primary Extend page
User interface changes
New tours
API changes
None
Technical pointers when creating tour tips
See: https://drupal.org/node/1921152#tour-tips-tech-note for tech notes on making tour tips.
Comment | File | Size | Author |
---|---|---|---|
#44 | tour-extend-2040861-44.patch | 3.41 KB | thejimbirch |
#18 | interdiff.txt | 4.15 KB | larowlan |
#5 | tour-extend-2040861-5.patch | 4.73 KB | nielsonm |
#1 | tour-extend-2040861.patch | 2.61 KB | lisarex |
Comments
Comment #1
lisarex CreditAttribution: lisarex commentedText was written and reviewed by colleagues
Comment #2
larowlanLooks good to me!
Comment #3
nick_schuch CreditAttribution: nick_schuch commentedTour needs tests since we now have #2028535
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedAdding missing tag.
Comment #5
nielsonm CreditAttribution: nielsonm commentedAdded a test to existing patch.
Comment #6
nielsonm CreditAttribution: nielsonm commentedFixed namespace error.
Comment #7
nielsonm CreditAttribution: nielsonm commentedAccidentally forgot to add the whole patch as well as the tests.
Comment #8
nielsonm CreditAttribution: nielsonm commentedTrying again on the merging the patches.
Comment #9
larowlanNote #1918768: Refactor tour module to use routes instead of paths just landed
Comment #10
nielsonm CreditAttribution: nielsonm commentedRe-rolled patch to use the new routing system.
Comment #11
nielsonm CreditAttribution: nielsonm commentedRerolled tests.
Comment #17
nielsonm CreditAttribution: nielsonm commentedBeen ported to routing system, but needs passing tests.
Comment #18
larowlanSo the issues with the tests are as follows:
also refactors TourTestBase to
Comment #21
larowlanSchema fails :-)
Comment #22
larowlanFixes schema fails, having that test in core is neat!
Comment #23
jibran22: extend-tour-2040861.16.patch queued for re-testing.
Comment #24
jibranSome suggestions
Can we make it www.drupal.org?
Can we explain search type? e.g. Partial match search or machine name search etc.
Isn't it a detail group now? In core we also have field and language groups.
Can't disable now. :P
This is cool.
I think this should be string[] now.
Please add a @todo to remove this.
Comment #25
jibranWe can add tip for uninstall tab as well.
Comment #26
nielsonm CreditAttribution: nielsonm commentedComment #27
batigolixFind attached an attempt for a beefier tour
Some questions:
Comment #28
larowlan1) I think left and right, but will need to consult the joyride documentation
2) Anything that jquery supports should work
3) I think workflow is a good idea
4) No worries
5) Default config should have uuids
6) If the data-class or data-id doesn't find anything, the JavaScript removes the tip from the dom.
Comment #29
nielsonm CreditAttribution: nielsonm commentedComment #30
dman CreditAttribution: dman commentedTracking this following a suggestion from Stefan over in #2040375-28: Write tour integration for Appearance pages as it looks to me like the generic "test all the things" framework here belongs in TourTestBasic for the rest of us to inherit rather than copy&paste.
Comment #33
webchickThis one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.
Comment #34
mgiffordComment #43
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedThis doesn't need to be postponed per xjm in https://www.drupal.org/project/drupal/issues/1921152#comment-12348895
Comment #44
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedAttached is a patch that updates the tour from #27 with additional changes:
I've also attached a screen recording of the tour.
Comment #48
smustgrave CreditAttribution: smustgrave at Mobomo commentedWill need a 10.1 patch
Also this will need tests.
Comment #49
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #51
quietone CreditAttribution: quietone at PreviousNext commentedThis extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.