Problem/Motivation

File field has a "Enable Display" field. Field settings:

screenshot

When you uploading files, file widget has "Display" checkbox. If it checked file formatter shows files for site visitors.

screenshot

ImageItem extends FileItem, but "Display" checkbox was removed from code.

CommentFileSizeAuthor
#24 2040033-24.patch4.96 KBivnish
#23 2023-11-10_17-53.png25.28 KBivnish
#23 2023-11-10_17-48.png27.76 KBivnish
#22 2040033-22.patch4.55 KB_utsavsharma
#22 interdiff_20-22.txt4.55 KB_utsavsharma
#20 core-2040033-20.patch5.26 KBivnish

Issue fork drupal-2040033

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GiorgosK’s picture

GiorgosK
Location Chios, Greece 🇬🇷
CreditAttribution: GiorgosK commented

Yes I vouch for this feature as well
I think it was part of the imagefield in drupal 6 then probably got dropped in drupal 7

dcam’s picture

dcam CreditAttribution: dcam commented
Title: Add a List-checkbox to imagefield » Add an "Include image in display" checkbox to the image field
Version: 7.22 » 8.1.x-dev
Component: image system » image.module
Issue summary: View changes

New features must be added to the current development version. I'm going to have to assume this hasn't been added D8. I can't check due to Image module installation problems of the on Windows platforms.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented

If there is any chance for this feature to be accepted in core I could spend some time looking into it.

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented

JFTR for my D8 site I decided to hide the image field by default and use entity_embed to show images when needed instead of hardcoding <img/> elements like I used to do in D6.

So I have no interest anymore in this feature.

Thanks,
Antonio

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ivnish’s picture

ivnish CreditAttribution: ivnish commented
Status: Active » Needs review
FileSize
core-2040033-20.patch5.26 KB

I made a quick and dirty patch for Drupal 9.5

Don't work with existing fields. Needs to remove image field from content type and add again

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs upgrade path, +Needs screenshots

Thanks for working on this old issue!

Will need test coverage and upgrade path for existing fields.

UI changes should have before/after screenshots added to issue summary.

Got the issue summary started but will need updating

_utsavsharma’s picture

_utsavsharma CreditAttribution: _utsavsharma commented
FileSize
interdiff_20-22.txt4.55 KB
2040033-22.patch4.55 KB

Rerolled for 11.x as #20 failed to apply.

ivnish’s picture

ivnish CreditAttribution: ivnish commented
Version: 11.x-dev » 10.1.x-dev
Issue summary: View changes
Issue tags: -Needs screenshots
FileSize
2023-11-10_17-48.png27.76 KB
2023-11-10_17-53.png25.28 KB
ivnish’s picture

ivnish CreditAttribution: ivnish commented
FileSize
2040033-24.patch4.96 KB

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ivnish opened merge request !7251