Now schema.module report with following error message:

download_count.ip_address is type varchar but its default 0 is PHP type integer
CommentFileSizeAuthor
#6 download_count-n2039451-6.patch1.1 KBDamienMcKenna
#5 download_count-n2039451-5.patch1.15 KBDamienMcKenna
#1 download_count-varchar_default_with_number-2039451-1.patch804 byteshswong3i
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Status: Active » Needs review
FileSize
download_count-varchar_default_with_number-2039451-1.patch804 bytes
WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented
Status: Needs review » Reviewed & tested by the community

thanks, I'll roll this in to the dev this weekend.

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented

welcome ;-)

deanflory’s picture

deanflory CreditAttribution: deanflory commented
Issue summary: View changes

Is this not yet applied to a release?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Reviewed & tested by the community » Needs review
FileSize
download_count-n2039451-5.patch1.15 KB

First off, the default should be an empty string rather than a zero. Secondly, there needed to be an update script to fix existing installs.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
download_count-n2039451-6.patch1.1 KB

Doh. No default value for NOT NULL fields.

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented
Status: Needs review » Fixed

Fix committed. Thanks again Damien!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.