Notice: Trying to get property of non-object in node_mollom_form_info()

I have the same problem on Drupal 7.23 and Mollom 7.x-2.7 ...

Thanks.
Didier

Sorry for the delay.

This notice appears, because one or more node/content types that previously existed, no longer exist. Most likely, because the content types were renamed or deleted.

As of now, the Mollom module does not have a mechanism for detecting the rename or deletion of a protected form. Thus, the configured forms are still the same, and it tries to retrieve information for the form that was previously protected.

Since it is borderline impossible to implement a generic mechanism for reacting to all renamed and deleted forms that may be provided by other modules (that integrate with Mollom), we should implement a mechanism to automatically remove stale/orphan form configurations.

And of course, the concrete offender of node_mollom_form_info() obviously needs to be adjusted to check whether the requested node type actually exists, before trying to operate further on it. :)

Attached patch implements a slightly more defensive approach — it fixes the warnings and notices, but only marks affected forms as "orphan" in the administrative list.

I did not want to automatically delete orphan entries, since the site administrator would not be aware of those deletions otherwise. (I also consider a warning message as insufficient, since Drupal still does not support persistent messages that need to be acknowledged; thus, if the wrong user happens to hit the page, the information would be lost.)

Are you able to test this patch on your site?

I apply the patch :

# cd sites/all/modules/mollom/

# patch -p1 < /home/didier/download/mollom.orphan-forms.3.patch 
patching file mollom.admin.inc
patching file mollom.module
Hunk #1 succeeded at 940 (offset 3 lines).
Hunk #2 succeeded at 1001 (offset 3 lines).
Hunk #3 succeeded at 3201 (offset 7 lines).
patching file tests/mollom.test

I clear the cache.
I go on the "Mollom moderation page" :

Ok, ALL error messages disappear.

(no "orphan" message...)

Thanks,

Sorry, further investigation revealed that this has the same root cause as #804466: Orphan forms of other modules cause errors on administration page

Thus, merging this issue (+ patch) into that one.