Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.


penyaskito’s picture

Issue tags: +D8MI, +sprint, +language-base

Tagging for tracking. Depends on #2005778: Convert language_admin_overview_form to a Controller, because the access controller may be committed there.

Pancho’s picture

Did you already start working on this? I believe this should merge into #2003592: Convert language_admin_add_form and language_admin_edit_form to a Controllers, because it really depends too much on that one.
The complex form should be broken up, as it UI-wise doesn't nicely degrade with JS being disabled. IMHO it should be a two-step form when JS is disabled, with the second step inheriting from the edit form. Only with JS being enabled, the edit form's elements - currently _language_admin_common_controls() - should be pulled in.
What do you think?

afeijo’s picture

I did started yet, but not much and it isn't working yet :)

This is my first task like that, I picked that one to learn the changes for D8 and to help

It make sense to merge with 2003592, I can help or I could move to another more basic similar issue

Pancho’s picture

While it's not really hard, it might be not one of the most basic conversion cases, but in the end most of them have some tricky part.
I'm gonna post a patch on the other issue by tomorrow. Would be awesome if you could review it and help figuring out the remaining pieces, including the access controller yet to be committed with #2005778: Convert language_admin_overview_form to a Controller.
Let's see then. Don't want to "steal" your issue, though... :/

afeijo’s picture

no worries, I'm not jealous :p

we can share it, by merge or submit both as separated patches. Ether way is fine by me

I will be honored to review your patch and to work with you to include language_admin_add_form()

Do you use irc? I'm often there

Gábor Hojtsy’s picture

Issue tags: +API change, +API clean-up

Add API change tags.

Pancho’s picture

Status: Postponed » Active

Sorry, we don't need to merge the two issues, it's absoutely enough if we postpone this one to #2003592: Convert language_admin_add_form and language_admin_edit_form to a Controllers, so you can build on the existing LanguageFormController()!
I'm happy to help, though, if help is needed.

Pancho’s picture

Status: Active » Postponed
Gábor Hojtsy’s picture

Status: Active » Postponed
Issue tags: -sprint

In that case, remove from sprint.

andypost’s picture

Status: Postponed » Closed (duplicate)

No reason to postpone this there's a lot of common functionality in both forms so require base class as imagestyles does.
So let's finish conversion in #2003592: Convert language_admin_add_form and language_admin_edit_form to a Controllers

This conversion require #2031277-11: Implement checkCreateAccess on LanguageAccessController

andypost’s picture

Issue summary: View changes

improve links