Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In order to being able to test and and also present the module and it's features in connection with the l10n_client module it would be a very nice feature to have a drush scenario builder integration.
This integration would be able to automatically setup a server with some example project, release and translations, as well as a client which is connected to this same server.
This would enable quick reviews of new features of the module and testing without prior manual setup of this entire environment.
Comment | File | Size | Author |
---|---|---|---|
#11 | l10n-scenario-builder-2037771-11.patch | 12.97 KB | s_leu |
#11 | l10n-scenario-builder-2037771-11-interdiff.txt | 1.4 KB | s_leu |
#9 | l10n-scenario-builder-2037771-9.patch | 13.19 KB | s_leu |
#9 | l10n-scenario-builder-2037771-9-interdiff.txt | 910 bytes | s_leu |
#7 | l10n-scenario-builder-2037771-7.patch | 13.21 KB | s_leu |
Comments
Comment #1
miro_dietikerFind here our presentation about the dsb project features ad Dev Days in Dublin.
http://dublin2013.drupaldays.org/node/92
This is the project page:
http://drupal.org/project/dsb
Done right, this is an enabler for participation: Complex multi system setups can be done within few minutes, including automated and content pre-population. Thus jumping into coding is easy.
While reviewing l10n_server and testing its functionality, we have written DSB integration.
Patch will follow soon.
Comment #2
s_leu CreditAttribution: s_leu commentedOk here's the patch finally
Comment #3
Gábor HojtsyI'm not sure this will be compatible much with different hosting environments (different hostnames, etc), but may be compatible with some. My only concern was that committing this may leave executable PHP/shell files in the project which may cause problems when loaded from the server and/or serve as injection points. Looking through I did not find a specific point where this would be an issue. Do you see any?
Comment #4
miro_dietikerdsb allows with local overrides to change hostnames / domains. (yes, we introduce something like a wildcard domain and all systems [server, client] we setup is below that domain.) You can override pretty anything. DSB is just a helper. And in case a different environment needs different adaptions, we are happy to add its specific requirements. For now no windows port :-)
I suggest moving to .inc for all script files. Thus all injection point concerns no more apply.
The dsb.config.php is similar to settings.php and only contains configuration arrays.
Comment #5
s_leu CreditAttribution: s_leu commentedadding a patch and interdiff with the suggested changes
Comment #6
miro_dietikerHere we go :-)
The .local domain leads to some trouble in certain local environments such as Mac. We thus decided to recommend *.dev for all scenarios.
Yes this todo needs to stay.
The other @todos are no more relevant or should be fixed.
Comment #7
s_leu CreditAttribution: s_leu commentedOk i made the suggested changes.
Comment #8
miro_dietikerIn case the workspace is the pwd, the --workspace is unneeded. Please check the latest dsb version.
Still the wrong / old pattern URL.
Is it possible to rely on the latest 7.x core version instead?
Comment #9
s_leu CreditAttribution: s_leu commentedchanges as suggested...
Comment #10
miro_dietikerAlmost :-)
Once double, once single quotes. No other pattern/reason.
The double quotes confuse me. Looks wrong.
And i still didn't figure out where you use pconfig. :-)
No reason to depend to simplenews. You download the .po file separately later.
DSB or dsb?
Comment #11
s_leu CreditAttribution: s_leu commented"Once double, once single quotes. No other pattern/reason."
The commands that contain a variable need double quotes, in order to escape the variables proper. Double quotes for the other commands aren't necessary, therefore i would leave it like it is now.
"No reason to depend to simplenews. You download the .po file separately later."
There is a good reason. If someone installs the client-server scenario, that person should be able to send some translations suggestions to the server. Since the only project, whose strings get imported on the server , is simplenews, we should have that project installed for the client. Otherwise it's not possible to send suggestions to the server and see them listed there as well.
I fixed the rest according to your comments:
Comment #12
miro_dietikerPattern / quotes: fine. Wasn't looking right :-)
Project dependencies: To make it less heavy, we could either use our own project l10n_client or l10n_server and make translation suggestions... or even introduce a hidden dummy module like with testing.
But it works as it is now and it is a good real example. Thus RTBC.
Comment #13
Gábor HojtsyYay, thanks, committed!